Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Test DTI eigenvectors #661
As pointed out by @RafaelNH here: #582, there seems to be some inconsistency about whether eigenvectors of tensors should be arranged column-wise or row-wise in 3-by-3 arrays. I am trying to enforce something uniform here. At the moment, this triggers several other test failures, but I wonder whether these are because of patching around this inconsistency, and would just require some additional fixing to make all parts consistent. I am continuing to investigate.
OK - I think that I have patched up all the subsequent test failures, but I'll wait to see if Travis comes up with something I've missed.
If there's one thing I've learned from this, it is how poorly our simulation module is covered. I had to rely on tests from all kinds of other modules (e.g. SHORE) to tell me that the "ground truth" simulation was doing it wrong.