New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed samuel st-jean email to the usherbrooke one #663

Merged
merged 2 commits into from Jun 25, 2015

Conversation

Projects
None yet
4 participants
@samuelstjean
Contributor

samuelstjean commented Jun 9, 2015

More professional than a gmail address.

@jchoude

This comment has been minimized.

Contributor

jchoude commented Jun 9, 2015

Which email address do you use for your commits? I would guess your gmail one... It's probably easier to keep the same, for easiness of mapping later on, but I'll let @Garyfallidis or others decide.

@samuelstjean

This comment has been minimized.

Contributor

samuelstjean commented Jun 9, 2015

Apparently I use this one also for commiting stuff

stjs2902 ~ $ [~] git config --global user.email
@usherbrooke.ca -> you get the idea

@arokem

This comment has been minimized.

Member

arokem commented Jun 24, 2015

Hey @samuelstjean - sorry for the delay (HBM, life...). Seems fine to me. There are a few people who commit with a few different email addresses. This is documented in the .mailmap file as well, so please change it there as well.

@samuelstjean

This comment has been minimized.

Contributor

samuelstjean commented Jun 24, 2015

Does .mailmap serves a purpose or it is not updated frequently? There seems to be few email addresses in there, and mine is not there, should I add it?

@matthew-brett

This comment has been minimized.

Member

matthew-brett commented Jun 24, 2015

Checkout https://www.google.com/?gws_rd=ssl#q=mailmap

.mailmap serves to identify two or more email addresses and commit names with the same person. You'll only see an address there if someone commits with more than one name / email pair.

@samuelstjean

This comment has been minimized.

Contributor

samuelstjean commented Jun 25, 2015

Oh ok, I did not know that. Anyway, I don't fall in thta usecase as my commit email is the one I am changing for in this current PR, the gmail one has never been used (yet, it'll probably come into usage when my academic one expire if I don't find another one by then).

@arokem

This comment has been minimized.

Member

arokem commented Jun 25, 2015

According to 'git -se', you've used the following emails to make commits:

Samuel St-Jean Samuel.St-Jean@usherbrooke.ca

Samuel St-Jean stjeansam@gmail.com
Samuel St-Jean qekchose@gmail.com

It would be good to have all of them in that .mailmap file.

On Wed, Jun 24, 2015 at 5:04 PM, Samuel St-Jean notifications@github.com
wrote:

Oh ok, I did not know that. Anyway, I don't fall in thta usecase as my
commit email is the one I am changing for in this current PR, the gmail one
has never been used (yet, it'll probably come into usage when my academic
one expire if I don't find another one by then).


Reply to this email directly or view it on GitHub
#663 (comment).

@samuelstjean

This comment has been minimized.

Contributor

samuelstjean commented Jun 25, 2015

Isn't that a garanteed recipe for tons of spam tough to have clear text emails everywhere online?

@arokem

This comment has been minimized.

Member

arokem commented Jun 25, 2015

Spam is a given.

arokem added a commit that referenced this pull request Jun 25, 2015

Merge pull request #663 from samuelstjean/change_email
changed samuel st-jean email to the usherbrooke one

@arokem arokem merged commit c3bd237 into nipy:master Jun 25, 2015

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@samuelstjean samuelstjean deleted the samuelstjean:change_email branch Jun 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment