Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
BF: added tolerance for negative streamline coordinates checks #678
In some case, tracts can be generated exactly on the border of the image volume. When mapped back to voxel coordinates, due to numerical imprecisions, they may have a coordinate with a value like -5.96046447754e-08, which trips up the negative coordinates test in _to_voxel_coordinates.
I added a tolerance to avoid rejecting valid points. Using a very small threshold so that genuinely invalid points still end up raising the error.
Of course! Just to make sure, you want a dataset that fails without this, or a new test in the testing framework?
If it's the latter, where should I put it: as a new test function in dipy.tracking.tests.test_utils.py, or as an additional test in, say, test_density_map of the same file?
added a commit
this pull request
Oct 26, 2015
I didn't mean that you should merge this without a test!
Now we're almost guaranteed that this will remain untested - sure way of
On Mon, Oct 26, 2015 at 7:34 AM, Eleftherios Garyfallidis <