New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for bval dimensionality on read. #708

Merged
merged 3 commits into from Sep 14, 2015

Conversation

Projects
None yet
3 participants
@arokem
Member

arokem commented Sep 1, 2015

This should fix #697.

As with the previous one: the first two commits are fixes to the issue, and the last commit is a bit of cleanup (PEP8, etc).

@jchoude

This comment has been minimized.

Contributor

jchoude commented Sep 2, 2015

Had a quick look, seems good. I'm no Travis expert, so I'll let @arokem or someone else have a look at why Travis is complaining.

@arokem

This comment has been minimized.

Member

arokem commented Sep 2, 2015

Seems like it's (finally?) complaining about #688. Maybe we merge #707 first, and then rebase this one on top of that, just to be on the safe side.

@arokem

This comment has been minimized.

Member

arokem commented Sep 2, 2015

But it does look like all our PRs from now on are going to fail until we deal with #688. See also: https://travis-ci.org/arokem/dipy/jobs/78445866

Garyfallidis added a commit that referenced this pull request Sep 14, 2015

Merge pull request #708 from arokem/fix-697
Check for bval dimensionality on read.

@Garyfallidis Garyfallidis merged commit 122ba1d into nipy:master Sep 14, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment