Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixes #715 #719
Yep - overall a good change to make, I think. With the one comment I made above about 'MDF'. My other comment is that it is now not entirely clear that this is emulating the default behavior, so you might want to point out which lines of code here would happen automatically, and what it would look like if you chose another setting (e.g.
Personally I prefer how
Another reason I prefer not showing explicitly
@Garyfallidis when you say "this makes it difficult for people who were used to the previous version of the algorithm." are you only talking about you :P (not a common user ;)) ? If you want we could make a function