Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
@sinkpoint's power map - refactored #724
Hi - here are a few suggestions on top of @sinkpoint's implementation of the Dell'Acqua power map (#672). I think that this would be very useful to have, but I have proposed a few changes relative to @sinkpoint's previous implementation that simplify the code and potentially lead to (marginally) faster performance. See here for a diff relative to #672 (ignore the top of this diff in
OK - here's what I've come up with: I am now testing this with a very simplified set of coefficients, that are all equal to 1. In this case, it is easy to calculate what AP should be equal to: it's the log of the number of even coefficients (because in this case the 2l+1 factors cancel out). Then, the normalization factor has to be taken into account, which I do here by varying that between two different quantities.
This seems like a better solution to me, because it tests the equation, rather than testing some other implementation of the same equation, on a specific test-set. I wouldn't mind having both in here, but I think this is sufficient.