New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: added test for _to_voxel_tolerance. #748

Merged
merged 1 commit into from Oct 26, 2015

Conversation

Projects
None yet
3 participants
@jchoude
Contributor

jchoude commented Oct 26, 2015

Added the test that was missing in PR #678

@arokem

This comment has been minimized.

Member

arokem commented Oct 26, 2015

Thanks! Going to find a hat to eat.

offset = np.array([0.5, 0.5, 0.5])
# Without the added tolerance in _to_voxel_coordinates, this streamline
# should raise an Error in the call to _to_voxel_coordinates.

This comment has been minimized.

@arokem

arokem Oct 26, 2015

Member

Can we test that with an assert_raises ?

This comment has been minimized.

@arokem

arokem Oct 26, 2015

Member

Oh - sorry - I see that makes no sense.

All good. I'll wait for travis to run this and then merge.

Again - thanks for filling that in!

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Oct 26, 2015

Much luv! Thx @jchoude!

arokem added a commit that referenced this pull request Oct 26, 2015

Merge pull request #748 from jchoude/TST_add_tolerance_test
TST: added test for _to_voxel_tolerance.

@arokem arokem merged commit df0b9f4 into nipy:master Oct 26, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jchoude jchoude deleted the jchoude:TST_add_tolerance_test branch Oct 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment