New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nlmeans use num threads option in 3d #849

Merged
merged 1 commit into from Jan 29, 2016

Conversation

Projects
None yet
3 participants
@samuelstjean
Contributor

samuelstjean commented Jan 29, 2016

So it was always using everything instead of the specified number, so now it's on par with the 4D version.

@arokem

This comment has been minimized.

Member

arokem commented Jan 29, 2016

Is there any way to test this, so that that this bug doesn't come creeping back?

@arokem

This comment has been minimized.

Member

arokem commented Jan 29, 2016

Speaking of which, any thoughts on #832? Did you just abandon that one?

@samuelstjean

This comment has been minimized.

Contributor

samuelstjean commented Jan 29, 2016

Half, fixed it on my side, thought we should get the float 32 or 64
tracking discussion going before. Not sure another test can be done, like
with the for loop in the recursive response, this is just a keyword that
got forgotten, can we even test this stuff? It's not like it was throwing
errors or wonky values.
On Jan 29, 2016 19:36, "Ariel Rokem" notifications@github.com wrote:

Speaking of which, any thoughts on #832
#832? Did you just abandon that one?


Reply to this email directly or view it on GitHub
#849 (comment).

@arokem

This comment has been minimized.

Member

arokem commented Jan 29, 2016

Yeah. I am not sure how to test this either. I think we can probably just
merge it without further ado. Anyone have any suggestions on this?

On Fri, Jan 29, 2016 at 1:44 PM, Samuel St-Jean notifications@github.com
wrote:

Half, fixed it on my side, thought we should get the float 32 or 64
tracking discussion going before. Not sure another test can be done, like
with the for loop in the recursive response, this is just a keyword that
got forgotten, can we even test this stuff? It's not like it was throwing
errors or wonky values.
On Jan 29, 2016 19:36, "Ariel Rokem" notifications@github.com wrote:

Speaking of which, any thoughts on #832
#832? Did you just abandon that one?


Reply to this email directly or view it on GitHub
#849 (comment).


Reply to this email directly or view it on GitHub
#849 (comment).

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Jan 29, 2016

All good! Thanks!

arokem added a commit that referenced this pull request Jan 29, 2016

Merge pull request #849 from samuelstjean/patch-5
nlmeans use num threads option in 3d

@arokem arokem merged commit 6fecc49 into nipy:master Jan 29, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@samuelstjean samuelstjean deleted the samuelstjean:patch-5 branch Feb 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment