New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miscellaneous Python 3 compatibility problem fixes in fvtk #853

Merged
merged 7 commits into from Feb 1, 2016

Conversation

Projects
None yet
4 participants
@grlee77
Contributor

grlee77 commented Jan 29, 2016

I was testing out fvtk (which is very nice by the way!) and encountered a number of small issues related to integer division, etc on Python 3 in both dipy.viz and a few of the examples.

I can omit b99d107 if you don't want that one here. It is related to future VTK 7.0 compatibility which I will discuss in a separate issue.

@arokem

This comment has been minimized.

Member

arokem commented Jan 29, 2016

Wait, VTK now works on Python 3?! That's incredible!

On Fri, Jan 29, 2016 at 3:11 PM, Gregory R. Lee notifications@github.com
wrote:

I was testing out fvtk (which is very nice by the way!) and encountered a
number of small issues related to integer division, etc on Python 3 in both
dipy.viz and a few of the examples.

I can omit b99d107
b99d107
if you don't want that one here. It is related to future VTK 7.0

compatibility which I will discuss in a separate issue.

You can view, comment on, or merge this pull request online at:

#853
Commit Summary

  • fix non-integer division problem for Python 3
  • Add Pillow compatibility to the have_imread test in dipy.viz.window
  • python 3 division compatibility in viz_slice.py
  • check if vtkVolumeTextureMapper2D is available in VTK
  • update print statement syntax in viz_widgets.py
  • add missing import to reconst_dsid.py
  • Enable introduction_to_basic_tracking.py to run when VTK is not
    present

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#853.

@grlee77

This comment has been minimized.

Contributor

grlee77 commented Jan 29, 2016

Yes, very soon! I encountered one error compiling using VTK 7.0 RC2, but got a patch for it accepted into the release branch by kitware so hopefully all will be well come the official 7.0 release.

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Feb 1, 2016

Thank you so much for doing this @grlee77 👯
It's great to know that the new dipy.viz works in VTK 7.

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Feb 1, 2016

And thank you of course for your corrections in this PR. All looks good! Have a nice day. 👍

Garyfallidis added a commit that referenced this pull request Feb 1, 2016

Merge pull request #853 from grlee77/viz_py3
miscellaneous Python 3 compatibility problem fixes in fvtk

@Garyfallidis Garyfallidis merged commit 2355db4 into nipy:master Feb 1, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@arokem

This comment has been minimized.

Member

arokem commented Feb 1, 2016

Should we set up a test bot with this version of VTK? Is it even out yet?

On Mon, Feb 1, 2016 at 7:58 AM, Eleftherios Garyfallidis <
notifications@github.com> wrote:

Merged #853 #853.


Reply to this email directly or view it on GitHub
#853 (comment).

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Feb 1, 2016

I think it's too early. I cannot find any available packages for VTK 7. Let's put a reminder for a month from now. They should start appearing soon. VTK 7 has some crazy features too. It is compatible with OpenGL ES!!! There is going to be a webinar speaking about the new features in two days from now https://blog.kitware.com/vtk-7-0-release-webinar

@grlee77

This comment has been minimized.

Contributor

grlee77 commented Feb 1, 2016

thanks for the quick merge! I am not sure of the exact VTK7 release date, but RC2 was released Jan 14 and the blog post about it stated "in a few weeks time", so definitely soon.

@matthew-brett

This comment has been minimized.

Member

matthew-brett commented Feb 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment