New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP8 #897

Merged
merged 2 commits into from Mar 3, 2016

Conversation

Projects
None yet
2 participants
@omarocegueda
Contributor

omarocegueda commented Feb 7, 2016

Closes issue #862. Verified with Spyder.

omarocegueda
@arokem

This comment has been minimized.

Member

arokem commented Feb 8, 2016

Thanks for taking a look. Spyder is apparently not aware of this one:

dipy/align/tests/test_crosscorr.py:40:5: E265 block comment should start with '# '
dipy/align/tests/test_crosscorr.py:44:5: E265 block comment should start with '# '
dipy/align/tests/test_crosscorr.py:48:5: E265 block comment should start with '# '
dipy/align/tests/test_crosscorr.py:56:5: E265 block comment should start with '# '
dipy/align/tests/test_crosscorr.py:85:5: E265 block comment should start with '# '
dipy/align/tests/test_crosscorr.py:89:5: E265 block comment should start with '# '
dipy/align/tests/test_crosscorr.py:110:5: E265 block comment should start with '# '
dipy/align/tests/test_crosscorr.py:130:5: E265 block comment should start with '# '
dipy/align/tests/test_crosscorr.py:134:5: E265 block comment should start with '# '
dipy/align/tests/test_crosscorr.py:144:5: E265 block comment should start with '# '
dipy/align/tests/test_crosscorr.py:172:5: E265 block comment should start with '# '
dipy/align/tests/test_crosscorr.py:176:5: E265 block comment should start with '# '
dipy/align/tests/test_crosscorr.py:199:5: E265 block comment should start with '# '
@arokem

This comment has been minimized.

Member

arokem commented Feb 8, 2016

To be clear, the hash sign (#) should be followed by space before the text. So:

#Select arbitrary images' shape (same shape for both images)

Should be:

# Select arbitrary images' shape (same shape for both images)
@arokem

This comment has been minimized.

Member

arokem commented Mar 1, 2016

Hey @omarocegueda - any chance to finish this up?

omarocegueda
@omarocegueda

This comment has been minimized.

Contributor

omarocegueda commented Mar 1, 2016

Sorry @arokem, I didn't see your comment! I just fixed the remaining issues.
You are right, Spyder didn't catch that, I also tried pep8 from here:
https://pypi.python.org/pypi/pep8
and it doesn't catch it either, what tool do you use?

@omarocegueda

This comment has been minimized.

Contributor

omarocegueda commented Mar 1, 2016

I just tried flake8 (following one of your previous comments) and it correctly found the issue, thanks! =)

@arokem

This comment has been minimized.

Member

arokem commented Mar 1, 2016

Great! 👍

@arokem

This comment has been minimized.

Member

arokem commented Mar 1, 2016

I'm going to go ahead and merge this, even though Travis isn't done, since that last commit is just innocuous whitespace.

arokem added a commit that referenced this pull request Mar 3, 2016

@arokem arokem merged commit 76d3b5f into nipy:master Mar 3, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment