New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pep8 errors in viz #908

Merged
merged 2 commits into from Feb 12, 2016

Conversation

Projects
None yet
2 participants
@ghoshbishakh
Member

ghoshbishakh commented Feb 11, 2016

fixes #890

@arokem

This comment has been minimized.

Member

arokem commented Feb 11, 2016

Thanks for contributing. I don't think you did anything wrong. I believe the failures on the Travis bot are due to updates in our dependencies. I'll post an issue about this, but we'll hold off on merging this in, until we can sort that out.

@@ -56,7 +55,8 @@ def sph_project(vertices, val, ax=None, vmin=None, vmax=None, cmap=None,
--------
>>> from dipy.data import get_sphere
>>> verts = get_sphere('symmetric724').vertices
>>> ax = sph_project(verts.T, np.random.rand(len(verts.T))) # skip if not has_basemap
>>> ax = sph_project(verts.T, np.random.rand(len(verts.T))) # skip

This comment has been minimized.

@arokem

arokem Feb 11, 2016

Member

Sorry - I was wrong. This change is the change that causes the test failures in the bots. Please change this line back.

This causes Travis to skip this test, when basemap is not present, and the Travis set up doesn't (usually) have this package.

@ghoshbishakh

This comment has been minimized.

Member

ghoshbishakh commented Feb 12, 2016

It is still inside the comment right? Changing it back gives the pep8 line too long. So can I solve it somehow?

@arokem

This comment has been minimized.

Member

arokem commented Feb 12, 2016

@arokem

This comment has been minimized.

Member

arokem commented Feb 12, 2016

In it goes. Thanks for the fix!

arokem added a commit that referenced this pull request Feb 12, 2016

@arokem arokem merged commit a8ed7b8 into nipy:master Feb 12, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ghoshbishakh

This comment has been minimized.

Member

ghoshbishakh commented Feb 12, 2016

thanks, Ill get back at the other pep8 s :)

@ghoshbishakh ghoshbishakh deleted the ghoshbishakh:pep8change branch Feb 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment