New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BW: skimage.filter module name warning #941

Merged
merged 1 commit into from Mar 23, 2016

Conversation

Projects
None yet
3 participants
@gauvinalexandre
Contributor

gauvinalexandre commented Feb 24, 2016

When using crop tools, I get this warning message. My fix solves it.

skimage_deprecation: The `skimage.filter` module has been renamed to `skimage.filters`.  This placeholder module will be removed in v0.13.
  warn(skimage_deprecation('The `skimage.filter` module has been renamed '

@gauvinalexandre gauvinalexandre changed the title from Fixed skimage.filter module name change to BW: skimage.filter module name warning Feb 24, 2016

@gauvinalexandre

This comment has been minimized.

Contributor

gauvinalexandre commented Mar 16, 2016

Hi @arokem or @Garyfallidis ! Is it possible to merge this single character fix shortly please? It would clean the console of warnings. I don't know if this causes backward incompatibility issues though... Thanks a lot !

@arokem

This comment has been minimized.

Member

arokem commented Mar 16, 2016

Do you know when this was changed in skimage? As I understand it, this will break things on some versions of skimage, but which?

@gauvinalexandre

This comment has been minimized.

Contributor

gauvinalexandre commented Mar 16, 2016

The change comes from:
scikit-image/scikit-image@78a7b73

@arokem

This comment has been minimized.

Member

arokem commented Mar 16, 2016

Yeah - I think it was removed in 0.11 (
http://scikit-image.org/docs/0.11.x/api_changes.html). Any idea when that
was released?

On Wed, Mar 16, 2016 at 10:33 AM, Alexandre Gauvin <notifications@github.com

wrote:

The change comes from:
scikit-image/scikit-image@78a7b73
scikit-image/scikit-image@78a7b73


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#941 (comment)

@arokem

This comment has been minimized.

Member

arokem commented Mar 16, 2016

April 2015 (https://github.com/scikit-image/scikit-image/tree/v0.11.x)

On Wed, Mar 16, 2016 at 10:45 AM, Ariel Rokem arokem@gmail.com wrote:

Yeah - I think it was removed in 0.11 (
http://scikit-image.org/docs/0.11.x/api_changes.html). Any idea when that
was released?

On Wed, Mar 16, 2016 at 10:33 AM, Alexandre Gauvin <
notifications@github.com> wrote:

The change comes from:
scikit-image/scikit-image@78a7b73
scikit-image/scikit-image@78a7b73


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#941 (comment)

@gauvinalexandre

This comment has been minimized.

Contributor

gauvinalexandre commented Mar 16, 2016

And according to here: https://github.com/scikit-image/scikit-image/releases, Mars 2015, So it's about a year ago. What do you suggest? How much time behind DIPY has to be backward compatible?

@arokem

This comment has been minimized.

Member

arokem commented Mar 16, 2016

Yeah. Seems fine to me.

BTW, this was previously fixed here: #749
and undone here: https://github.com/nipy/dipy/pull/695/files

Maybe @matthieudumont or @Garyfallidis have some opinion about this.

@arokem

This comment has been minimized.

Member

arokem commented Mar 23, 2016

Any feedback here @matthieudumont / @Garyfallidis ? Why was this changed back in that PR?

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Mar 23, 2016

Accidentally.

@Garyfallidis Garyfallidis merged commit 6bff565 into nipy:master Mar 23, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@arokem

This comment has been minimized.

Member

arokem commented Mar 23, 2016

Thanks!

On Wed, Mar 23, 2016 at 7:53 AM, Eleftherios Garyfallidis <
notifications@github.com> wrote:

Merged #941 #941.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#941 (comment)

@gauvinalexandre

This comment has been minimized.

Contributor

gauvinalexandre commented Mar 23, 2016

Thank you very much all !

@gauvinalexandre gauvinalexandre deleted the gauvinalexandre:skimage branch Mar 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment