Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Slicer fix #944
I discovered a major contradiction and bug in the value scaling and lookup table making of the slicer feature. I found the way to make it work. Therefore, the behavior of the slicer changed and the test_fvtk_actors fails, probably with reason. It has to be adapted. I'll need help, since I don't know how to interpret the error. Also, there were some mistakes in the doc-strings. I took the occasion to clean the code. I've tested the Slicer with VTK 5 and 6 the best I could and ran the fvtk_actor test. Everything looks good.
referenced this pull request
Jun 17, 2016
Here is a first review @gauvinalexandre Let me know what you think. Clamping and interpolation are two different things. We probably should try to support both.
We should also call (optionally) this function for removing outliers. Often most images have only a few outliers with high intensity values and the interpolation generates images with less contrast.
Current coverage is 85.44% (diff: 33.33%)
@@ master #944 diff @@ ========================================== Files 214 214 Lines 24917 24917 Methods 0 0 Messages 0 0 Branches 2526 2526 ========================================== - Hits 21296 21291 -5 - Misses 2989 2995 +6 + Partials 632 631 -1