New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PEP8 in boots #948

Merged
merged 2 commits into from Mar 11, 2016

Conversation

Projects
None yet
2 participants
@ghoshbishakh
Member

ghoshbishakh commented Feb 29, 2016

fixes #872

@@ -1,15 +1,21 @@
#!/usr/bin/python
#import modules
# import modules

This comment has been minimized.

@arokem

arokem Mar 1, 2016

Member

Strangest comment I've seen. Would you mind removing it?

, statistic) -
2 * __tt(x, p_0, statistic) ) / eps**2
c_q_hat = (__tt(x, (1 - eps) * p_0 + eps * tt_dot /
(n**2 * sigma_hat), statistic) +

This comment has been minimized.

@arokem

arokem Mar 1, 2016

Member

For clarity, I would enclose the things that go together in parentheses:

(__tt(x, ((1 - eps) * p_0) +
        (eps * tt_dot / (n**2 * sigma_hat)), statistic ...
c_q_hat = (__tt(x, (1 - eps) * p_0 + eps * tt_dot /
(n**2 * sigma_hat), statistic) +
__tt(x, (1 - eps) * p_0 - eps * tt_dot /
(n**2 * sigma_hat), statistic) -

This comment has been minimized.

@arokem

arokem Mar 1, 2016

Member

Same here

@arokem

This comment has been minimized.

Member

arokem commented Mar 1, 2016

A couple of small things. Otherwise, looks good to me.

import sys
import os
import traceback
import optparse

This comment has been minimized.

@ghoshbishakh

ghoshbishakh Mar 1, 2016

Member

@arokem atually if you inspect the modules are not used in the entire code.
time, sys, os, traceback, optparse, also rom copy import copy, deepcopy
these are never used. So should they be cleaned up?

This comment has been minimized.

@arokem

arokem Mar 1, 2016

Member

Yes - good call. Please do remove . Running pyflakes (https://pypi.python.org/pypi/pyflakes) or flake8 ( https://pypi.python.org/pypi/flake8) on this should also tell you about unused modules, so you can verify that you are not removing something necessary.

@ghoshbishakh

This comment has been minimized.

Member

ghoshbishakh commented Mar 2, 2016

@arokem I hope it is ok?

@arokem

This comment has been minimized.

Member

arokem commented Mar 2, 2016

Yeah. Looks good to me. Anyone else want to take a look?

arokem added a commit that referenced this pull request Mar 11, 2016

@arokem arokem merged commit c62daa2 into nipy:master Mar 11, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment