New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: PEP8 in core #963

Merged
merged 3 commits into from Mar 11, 2016

Conversation

Projects
None yet
2 participants
@manu-tej
Contributor

manu-tej commented Mar 3, 2016

issues in #873 fixed

@@ -978,7 +978,8 @@ def perpendicular_directions(v, num=30, half=False):
\frac{v_{y}v_{z}\sin(a_{i})+v_{x}\cos(a_{i})}
{\sqrt{{v_{x}}^{2}+{v_{z}}^{2}}} \right ]
For more details on this calculation, see ` here <http://gsoc2015dipydki.blogspot.it/2015/07/rnh-post-8-computing-perpendicular.html>`_.
For more details on this calculation, see ` here
<http://gsoc2015dipydki.blogspot.it/2015/07/rnh-post-8-computing-perpendicular.html>`_.

This comment has been minimized.

@arokem

arokem Mar 5, 2016

Member

This needs to be all on line for that link to be properly rendered.

@@ -55,9 +55,9 @@
"""
from __future__ import division, print_function, absolute_import
#-----------------------------------------------------------------------------
# -----------------------------------------------------------------------------

This comment has been minimized.

@arokem

arokem Mar 5, 2016

Member

This is just a visual separator. No need to take pep8 too literally...

# Classes and Functions
#-----------------------------------------------------------------------------
# -----------------------------------------------------------------------------

This comment has been minimized.

@arokem

arokem Mar 5, 2016

Member

Same here.

@@ -206,9 +206,9 @@ def auto_attr(func):
return OneTimeProperty(func)
#-----------------------------------------------------------------------------
# -----------------------------------------------------------------------------

This comment has been minimized.

@arokem

arokem Mar 5, 2016

Member

And here

# Deprecated API
#-----------------------------------------------------------------------------
# -----------------------------------------------------------------------------

This comment has been minimized.

@arokem

arokem Mar 5, 2016

Member

And here.

@arokem

This comment has been minimized.

Member

arokem commented Mar 5, 2016

Nice. Thanks for doing that. Just a couple of small comments. In particular, please change back that link to the blog post. Otherwise, this doesn't render properly in the docs.

@manu-tej manu-tej force-pushed the manu-tej:pep8_core branch from 8414abf to e422517 Mar 5, 2016

@arokem

This comment has been minimized.

Member

arokem commented Mar 5, 2016

Tests are now all passing on my machine. Looks good to go on my end, but I will let others take a look if they want.

arokem added a commit that referenced this pull request Mar 11, 2016

@arokem arokem merged commit 3d91f67 into nipy:master Mar 11, 2016

@ghoshbishakh ghoshbishakh referenced this pull request Mar 15, 2016

Closed

PEP8 in core #873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment