New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: PEP8 in test_imaffine #964

Merged
merged 3 commits into from Mar 11, 2016

Conversation

Projects
None yet
2 participants
@riddhishb
Contributor

riddhishb commented Mar 7, 2016

pep 8 for test_imaffine.py. Issue #864

Riddhish Bhalodia added some commits Mar 7, 2016

@@ -467,7 +482,8 @@ def test_affine_map():
expected_nn = oracle_nn(img, dom_shape[:dim], aff_inv_inv)
affine_map = imaffine.AffineMap(aff_inv,
cod_shape[:dim], codomain_grid2world,
cod_shape[
:dim], codomain_grid2world,

This comment has been minimized.

@arokem

arokem Mar 7, 2016

Member

I prefer not to break in the middle of an indexing operation. Can you break this line after the comma?

@arokem

This comment has been minimized.

Member

arokem commented Mar 7, 2016

One small comment. Other than that, looks good.

@riddhishb

This comment has been minimized.

Contributor

riddhishb commented Mar 7, 2016

Check Now

@arokem

This comment has been minimized.

Member

arokem commented Mar 7, 2016

Yeah. This now looks good to me. If someone else wants to take a look, that would be great.

For some reason, the Travis CI system was turned off for dipy. I just flipped the switch back on for that, so future commits on all PRs should trigger a run of the tests.

@arokem arokem referenced this pull request Mar 7, 2016

Closed

STYLE:PEP8 for test_imaffine #920

@arokem

This comment has been minimized.

Member

arokem commented Mar 11, 2016

Tests pass on my laptop. I'm merging.

arokem added a commit that referenced this pull request Mar 11, 2016

@arokem arokem merged commit c7f7a83 into nipy:master Mar 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment