New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor change in `tools/github_stats.py` #974

Merged
merged 3 commits into from Apr 13, 2016

Conversation

Projects
None yet
2 participants
@manu-tej
Contributor

manu-tej commented Mar 19, 2016

Fixed the issue #973

@@ -177,7 +177,10 @@ def report(issues, show_urls=False):
all_authors = check_output(author_cmd).splitlines()
unique_authors = sorted(set(all_authors))
print("The following %i authors contributed %i commits." % (len(unique_authors), ncommits))
if (len(unique_authors) != 0):

This comment has been minimized.

@arokem

arokem Mar 20, 2016

Member

How about the following?

if len(unique_authors) == 0:
    print("No commits during this period.")
else: 
   ... do all the rest
print("The following %i authors contributed %i commits." % (len(unique_authors), ncommits))
+ print()
print('\n'.join(unique_authors))
print()
print()
print("We closed a total of %d issues, %d pull requests and %d regular issues;\n"

This comment has been minimized.

@arokem

arokem Mar 28, 2016

Member

I'd include this block in the else block

@arokem

This comment has been minimized.

Member

arokem commented Apr 4, 2016

LGTM. I'll let others take a look, before merging.

@arokem arokem merged commit 7b6ce30 into nipy:master Apr 13, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment