New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP8 in sims #884 #983

Closed
wants to merge 8 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@theaverageguy
Contributor

theaverageguy commented Mar 21, 2016

Fixes #884

@@ -66,7 +68,7 @@ def test_add_noise():
N = 50
S0 = 100
options = dict(func=f,
options=dict(func=f,

This comment has been minimized.

@arokem

arokem Mar 21, 2016

Member

This was actually fine before, I believe.

evecs=all_tensor_evecs(
sticks[i]), snr=None)
S = S + fractions[i] * single_tensor(gtab, S0=S0, evals=mevals[i],
evecs=all_tensor_evecs(sticks[i]), snr=None)

This comment has been minimized.

@arokem

arokem Mar 21, 2016

Member

Is this still <80 characters?

If you need to, you can put a newline right before snr

@arokem

This comment has been minimized.

Member

arokem commented Mar 21, 2016

Thanks. A few small comments.

theaverageguy added some commits Mar 21, 2016

@theaverageguy

This comment has been minimized.

Contributor

theaverageguy commented Mar 21, 2016

Fixed both.

@@ -78,7 +80,7 @@ def test_add_noise():
vol = orbital_phantom(gtab, **options)
for snr in [10, 20, 30, 50]:
vol_noise = orbital_phantom(gtab, snr=snr, **options)
vol_noise = orbital_phantom(gtab, snr = snr, **options)

This comment has been minimized.

@arokem

arokem Mar 21, 2016

Member

Sorry - missed this one before. This = shouldn't have whitespace around it.

@arokem

This comment has been minimized.

Member

arokem commented Mar 21, 2016

Real close here. One more teensy comment.

@theaverageguy

This comment has been minimized.

Contributor

theaverageguy commented Mar 22, 2016

Fixing it in 5!

@arokem

This comment has been minimized.

Member

arokem commented Mar 23, 2016

Did you get a chance to fix this one?

@arokem

This comment has been minimized.

Member

arokem commented Mar 28, 2016

This one needs a rebase.

@arokem

This comment has been minimized.

Member

arokem commented Apr 4, 2016

Hey @theaverageguy : mind giving this one a rebase? It's got some conflicts with other things that got merged into master since.

@arokem

This comment has been minimized.

Member

arokem commented Oct 21, 2016

I assume this has been abandoned, but feel free to reopen if you still want to work on this.

@arokem arokem closed this Oct 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment