New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: embedding issue #306

Merged
merged 1 commit into from Feb 11, 2019

Conversation

Projects
None yet
2 participants
@mgxd
Copy link
Member

mgxd commented Feb 6, 2019

Closes #291.

Fixes an issue where dcmstack output was not indexed properly (due to the change in moloney/dcmstack@3815ea2). This "silent" error was avoided when using the --minmeta flag.

Changes

  • stack is set as the first iterated item of dcmstack's parse_and_stack()
  • Parameter force of embed_nifti() was removed and automatically applied within.
  • Test for various uses of embed_nifti()
@utooley

This comment has been minimized.

Copy link

utooley commented Feb 7, 2019

Does this affect previous output when the --minmeta flag was not used and the embedder error occurred?

@mgxd

This comment has been minimized.

Copy link
Member Author

mgxd commented Feb 7, 2019

@utooley if you received the embedding issue, it should look very similar to having used the --minmeta flag (just dcm2niix sidecar JSON)

@utooley

This comment has been minimized.

Copy link

utooley commented Feb 7, 2019

Ah great--thanks so much @mgxd! I was assuming that --minmeta would be sufficient information to continue ppc-ing, if I have trouble figuring out some bit of info, I'll rerun. That's really helpful, thanks!

@mgxd mgxd merged commit 8be2e9b into nipy:master Feb 11, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment