Skip to content

Loading…

roi module needs tests and rework #75

Open
matthew-brett opened this Issue · 3 comments

2 participants

@matthew-brett
NIPY developers member

The ROI module won't work as it is now, and needs a rethink / rewrite now that the various APIs have changed. That's nipy/core/image/roi.py

@bthirion

I propose that the modules in
nipy.labs.spatial_models
could be used in that respect, in particular discrete_domain.py and mroi.py
I'm open to suggestions for API changes.

See the examples in examples/labs/, in particular
https://github.com/bthirion/nipy/blob/master/examples/labs/need_data/demo_roi.py

Best,

Bertrand

@matthew-brett
NIPY developers member

I propose removing the ROI module here: #180

@matthew-brett
NIPY developers member

Removed in commit 6f19113 - last commit containing roi module is 2b67776.

Keeping this issue open for discussion of roi API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.