Rethinking xyz #162

Merged
merged 2 commits into from May 19, 2012

Conversation

Projects
None yet
2 participants
Owner

matthew-brett commented May 17, 2012

Refactoring and fixing calculations of the XYZ affine to take into account dropped dimensions.

In the process, I discovered a bug in nibabel io_orientation requiring a temporary fix in the nipy tree.

Contributor

bthirion commented May 18, 2012

It runs on my box. The constraint on dimension and axis order sounds reasonable.

What appends with affine_image and wyz_image in nipy.core.image ? They seem to need some more love...

Owner

matthew-brett commented May 18, 2012

Very good point - I am hoping to be able to remove affine_image and xyz_image - that should be possible soon after mergin some changes I'll propose later on today.

matthew-brett added some commits May 16, 2012

@matthew-brett matthew-brett BF: copy fixed io_orientations from nibabel trunk
There was a nasty bug in io_orientations in nibabel, that could cause
the process to hang when getting orientations for affines will all-zero
columns.  To allow use of nibabel 1.2.0, copy the fix into our fixes
tree until we depend on a later nibabel.
964f283
@matthew-brett matthew-brett RF+BF: simplify meaning of xyz_affine
I was trying to be too fancy, because I was trying to return a valid xyz
affine for coordmaps that did not have output order X, Y, Z.  In the
process I got confused and failed to check the correspondence of input
and output axes, letting past cases where input axes had been dropped or
were in the wrong order.
9cfbef9

matthew-brett merged commit 8ec520e into nipy:master May 19, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment