Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

MRG: Fix type graph #263

Merged
merged 5 commits into from

2 participants

@bthirion
Collaborator

This PR aims at solving issue #256 by casting to float 64 the arrays that need to.
I took this opportunity to clean the tests in nipy.algorithms.graph.

@matthew-brett

It seems a bit ugly to change the dtype as a result of a call to one particular method. That means that two calls to the same method could give different results before and after a call to 'local_maxima' which seems bad.

Could you enforce (via properties) that field is always float64? Or could you use temporary arrays in this function instead, not changing the objects?

@bthirion
Collaborator

Should be OK now
Noet however that field is changed in-place in this function (although, when using this for local maxima extraction, the field is a copy of the initial data)

@matthew-brett

Um - am I right in thinking that the data is not changed in type, in-place, anymore?

@bthirion
Collaborator

Yes, there is no arbitrary dtype change left in the dilation function.

@matthew-brett

Bertrand - OK - to merge this one?

@bthirion
Collaborator

Sure.

@matthew-brett matthew-brett merged commit 9df4e65 into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.