Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Contrast #301

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

jonathan-taylor commented Oct 31, 2013

Tried adding a "show_contrast" method to DesignMatrix.

Also added cmap arguments to both show* methods.

Coverage Status

Coverage remained the same when pulling 6a65f26 on jonathan-taylor:contrast into 8e65d4a on nipy:master.

Owner

matthew-brett commented Oct 31, 2013

Thanks. Can you add tests?

For tests of stuff using matplotlib, there's an example here:

https://github.com/nipy/nipy/blob/master/nipy/tests/test_scripts.py#L33

Contributor

jonathan-taylor commented Oct 31, 2013

Added tests for show_contrasts.

On Thu, Oct 31, 2013 at 11:37 AM, Matthew Brett notifications@github.comwrote:

Thanks. Can you add tests?

For tests of stuff using matplotlib, there's an example here:

https://github.com/nipy/nipy/blob/master/nipy/tests/test_scripts.py#L33


Reply to this email directly or view it on GitHubhttps://github.com/nipy/nipy/pull/301#issuecomment-27513393
.

Jonathan Taylor
Dept. of Statistics
Sequoia Hall, 137
390 Serra Mall
Stanford, CA 94305
Tel: 650.723.9230
Fax: 650.725.8977
Web: http://www-stat.stanford.edu/~jtaylo

Coverage Status

Coverage remained the same when pulling 9a0ddf0 on jonathan-taylor:contrast into 8e65d4a on nipy:master.

Owner

matthew-brett commented Nov 1, 2013

Thanks for the contrasts test. Can you think of tests for the automatic main effect for one factor?

Add test for atleast_2d for show_contrast?

Owner

matthew-brett commented Sep 25, 2015

OK - I will rebase this one, add some tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment