MRG: new numpy protects polynomial coefficients #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jonathan-taylor - does this look right to you? I couldn't see any reason the coefficients had to be inside a poly object... |
New numpy returns a copy of the polynomial coefficients from poly.c, rather than the actual coefficent array, so when we were modifying the polynomial coefficients, the polynomial object wasn't seeing our changes, leading to errors in the RFT module - see e.g. https://nipy.bic.berkeley.edu/builders/nipy-py2.7-osx-10.10/builds/52/steps/shell_9/logs/stdio Numpy issue raised on numpy-discussion mailing list.
matthew-brett
force-pushed
the
fix-numpy-1.13-breakage
branch
from
944621e
to
c35c0d9
Compare
|
Changes Unknown when pulling c35c0d9 on matthew-brett:fix-numpy-1.13-breakage into ** on nipy:master**. |
|
Superseded by (quite independent repeat) fix in #435 |
Codecov Report
@@ Coverage Diff @@
## master #431 +/- ##
=========================================
Coverage ? 83.25%
=========================================
Files ? 301
Lines ? 28190
Branches ? 3280
=========================================
Hits ? 23469
Misses ? 3719
Partials ? 1002
Continue to review full report at Codecov.
|
|
On second thoughts, I'll merge this one, and rebase the later one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New numpy returns a copy of the polynomial coefficients from poly.c,
rather than the actual coefficent array, so when we were modifying the
polynomial coefficients, the polynomial object wasn't seeing our
changes, leading to errors in the RFT module - see e.g.
https://nipy.bic.berkeley.edu/builders/nipy-py2.7-osx-10.10/builds/52/steps/shell_9/logs/stdio
Numpy issue raised on numpy-discussion mailing list.