Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Reliably parse SGE job IDs in the presence of warnings #3168

Merged
merged 1 commit into from Feb 12, 2020

Conversation

bloyl
Copy link
Contributor

@bloyl bloyl commented Feb 11, 2020

Summary

Fixes #3164

List of changes proposed in this PR (pull-request)

  • added regex to awk command extracting job_ids for sge jobs

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@codecov
Copy link

codecov bot commented Feb 11, 2020

Codecov Report

Merging #3168 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3168   +/-   ##
=======================================
  Coverage   67.61%   67.61%           
=======================================
  Files         299      299           
  Lines       39494    39494           
  Branches     5219     5219           
=======================================
  Hits        26702    26702           
  Misses      12083    12083           
  Partials      709      709           
Flag Coverage Δ
#smoketests 53.04% <0.00%> (ø) ⬆️
#unittests 64.86% <0.00%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b62d806...1732136. Read the comment docs.

@effigies effigies changed the base branch from master to maint/1.4.x February 12, 2020 14:35
@effigies effigies changed the title FIX Issue 3164 FIX: Reliably parse SGE job IDs in the presence of warnings Feb 12, 2020
@effigies effigies changed the base branch from maint/1.4.x to master February 12, 2020 14:36
@effigies
Copy link
Member

Was going to suggest merging this into maint/1.4.x, but the next planned release is 1.5.0. We can consider backporting later.

@effigies effigies merged commit 978579b into nipy:master Feb 12, 2020
@effigies effigies added this to the 1.4.2 milestone Feb 14, 2020
@effigies effigies mentioned this pull request Feb 14, 2020
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sgegraph only submits the next processing node
2 participants