Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in inputs checksum before/after task run when deeply modifying objects #571

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

tclose
Copy link
Contributor

@tclose tclose commented Aug 29, 2022

Types of changes

  • Bug fix

Summary

Deep copy original inputs when saving to restore after task has been run, primarily so that checksum doesn't change after the task has been run (making the node undiscoverable by downstream nodes)

Checklist

  • I have added tests to cover my changes (if necessary): N/A
  • I have updated documentation (if necessary): N/A

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Base: 77.06% // Head: 77.06% // No change to project coverage 👍

Coverage data is based on head (3219549) compared to base (5f5044d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #571   +/-   ##
=======================================
  Coverage   77.06%   77.06%           
=======================================
  Files          20       20           
  Lines        4316     4316           
  Branches     1212     1213    +1     
=======================================
  Hits         3326     3326           
  Misses        802      802           
  Partials      188      188           
Flag Coverage Δ
unittests 76.96% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pydra/engine/core.py 88.97% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@djarecka djarecka merged commit 219c721 into nipype:master Aug 31, 2022
@tclose tclose deleted the inputs-checksum-fix branch September 20, 2022 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants