Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It's unclear that primitive type "uri" enclose URNs (not only URLs) #126

Closed
Kroisse opened this issue Mar 23, 2017 · 3 comments
Closed

It's unclear that primitive type "uri" enclose URNs (not only URLs) #126

Kroisse opened this issue Mar 23, 2017 · 3 comments
Labels
cat:lang Category: Language design cmp:compiler Component: Compiler backend (e.g., annotation processors, code generators) cmp:runtime Component: Target runtimes dfct:easy Difficulty: Easy typ:refactor Type: Refactoring (i.e., the same feature to end users but its internal change)
Projects
Sprint at Seoul in February 2018 Sprint at Seoul in May 2018
Milestone
Version 0.5.0

Comments

@Kroisse
Copy link
Contributor

Kroisse commented Mar 23, 2017

Currently, Nirum specification doesn't clarify their implementors to treat "uri" be a union of Uniform Resource Locator and Uniform Resource Name, or accept URL only and reject URN. Because URN is used rarely in practice, most of Nirum users might want to exclude URN during serialization and deserialization. Furthermore, most of programming languages don't have URN datatype in their standard library. It makes hard to implement the runtime for them.
@dahlia
Copy link
Member

dahlia commented Mar 23, 2017

I suggest to rename uri to url.

@dahlia dahlia added the typ:refactor Type: Refactoring (i.e., the same feature to end users but its internal change) label Mar 23, 2017
@dahlia dahlia added cat:lang Category: Language design cmp:compiler Component: Compiler backend (e.g., annotation processors, code generators) cmp:runtime Component: Target runtimes labels Aug 26, 2017
@dahlia dahlia added this to the Version 0.5.0 milestone May 5, 2018
@dahlia dahlia added the dfct:easy Difficulty: Easy label May 5, 2018
@Jhuni0123 Jhuni0123 self-assigned this May 21, 2018
Jhuni0123 added a commit to Jhuni0123/nirum that referenced this issue May 21, 2018
@Jhuni0123
Rename Uri to Url (uri remains deprecated)
1e864fa 
nirum-lang#126
Jhuni0123 added a commit to Jhuni0123/nirum that referenced this issue May 21, 2018
@Jhuni0123
Rename uri to url (uri remains deprecated)
dbbe136 
nirum-lang#126
@Jhuni0123 Jhuni0123 mentioned this issue May 21, 2018
Merged
Jhuni0123 added a commit to Jhuni0123/nirum that referenced this issue May 21, 2018
@Jhuni0123
Rename uri to url (uri remains deprecated)
140db5b 
nirum-lang#126
Jhuni0123 added a commit to Jhuni0123/nirum that referenced this issue May 21, 2018
@Jhuni0123
Rename uri to url (uri remains deprecated)
e0109d6 
nirum-lang#126
@dahlia
Copy link
Member

dahlia commented May 21, 2018

The compiler 0.4 will be released with a new type name url and deprecated uri (which is aliased to url).

In the next minor release we need to obsolete uri.

Jhuni0123 added a commit to Jhuni0123/nirum that referenced this issue May 25, 2018
@Jhuni0123
completely deprecate uri
c2586ef 
nirum-lang#126
@Jhuni0123 Jhuni0123 mentioned this issue May 25, 2018
Merged
@dahlia
Copy link
Member

dahlia commented Aug 17, 2018

PR #281 implemented it.

@dahlia dahlia closed this as completed Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cat:lang Category: Language design cmp:compiler Component: Compiler backend (e.g., annotation processors, code generators) cmp:runtime Component: Target runtimes dfct:easy Difficulty: Easy typ:refactor Type: Refactoring (i.e., the same feature to end users but its internal change)
Projects
No open projects
Sprint at Seoul in February 2018
  
Chosen
Sprint at Seoul in May 2018
  
Chosen
Milestone
Version 0.5.0
Development

No branches or pull requests
3 participants
@dahlia @Kroisse @Jhuni0123