Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making client class under its service interface namespace #167

Closed
kanghyojun opened this issue Aug 15, 2017 · 0 comments

Comments

@kanghyojun
Copy link
Member

commented Aug 15, 2017

The compiler currently generates a pair of an interface and its client class for each service e.g.:

class FooService(Service):
    ...

class FooService_Client(FooService):
    ...

Making client classes under their interface namespace would be better for avoiding namespace pollution e.g.:

class FooService(Service):
    ...

class FooService_Client(FooService):
    ...

FooService.Client = FooService_Client
qria added a commit to qria/nirum that referenced this issue Feb 9, 2018
qria added a commit to qria/nirum that referenced this issue Feb 9, 2018

@dahlia dahlia moved this from Chosen to In progress in Sprint at Seoul in February 2018 Feb 9, 2018

qria added a commit to qria/nirum that referenced this issue Feb 9, 2018
qria added a commit to qria/nirum that referenced this issue Feb 9, 2018
qria added a commit to qria/nirum that referenced this issue Feb 10, 2018

@dahlia dahlia closed this in #222 Feb 10, 2018

Sprint at Seoul in February 2018 automation moved this from In progress to Delivered Feb 10, 2018

dahlia added a commit that referenced this issue Feb 10, 2018
Merge pull request #222 from qria/issue-167
#167: Add Client class under Service class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.