Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest renaming boxed keyword to unboxed #65

Closed
dahlia opened this issue Aug 22, 2016 · 3 comments

Comments

@dahlia
Copy link
Member

commented Aug 22, 2016

As @Kroisse previously addressed by word of mouth, the meaning of boxed is misleading since boxed types are actually not boxed when it comes to JSON!

So I suggest: how about renaming boxed keyword to unboxed? Although it becomes two letters longer, I believe it would be more predictable and less misleading.

@dahlia dahlia added the typ:enhance label Aug 22, 2016

@Kroisse

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2016

I think that it's not necessary to imply its implementation details on the keyword name, so neither boxed nor unboxed are inappropriate.

If I should to choice in that names, I prefer unboxed, by the same reason @dahlia said.

@dahlia

This comment has been minimized.

Copy link
Member Author

commented Aug 22, 2016

@Kroisse I'm not with you. How types are serialized in JSON are not just implementation detail, but sort of what users have to be aware of. If it's just implementation detail we should remove enum and boxed because they can be generalized using union and record.

@dahlia dahlia changed the title Suggest renaming boxed keyword Suggest renaming boxed keyword to unboxed Sep 20, 2016

@dahlia

This comment has been minimized.

Copy link
Member Author

commented Sep 20, 2016

Although there could be better alternatives to unboxed, I believe unboxed is way better than boxed at least. If we don't have enough time to search better candidates than unboxed I still suggest to rename boxed to unboxed. (@admire93 has coded that uses boxed keyword at @spoqa, and we're getting less opportune to rename it day by day.)

@dahlia dahlia self-assigned this Sep 23, 2016

dahlia added a commit to dahlia/nirum-python that referenced this issue Sep 23, 2016
dahlia added a commit to dahlia/nirum-python that referenced this issue Sep 23, 2016
dahlia added a commit to dahlia/nirum that referenced this issue Sep 23, 2016
dahlia added a commit to dahlia/nirum-python that referenced this issue Sep 23, 2016
kanghyojun added a commit to nirum-lang/nirum-python that referenced this issue Sep 25, 2016
@dahlia dahlia referenced this issue Sep 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.