Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs Support #10

Closed
wants to merge 14 commits into from

Conversation

@dahlia
Copy link
Member

commented May 19, 2016

Although this branch is working in progress, I early open this pull request to share its progress.

The following is the list to do:

  • AST for CommonMark
  • HTML renderer

@dahlia dahlia added the typ:enhance label May 19, 2016

@dahlia dahlia self-assigned this May 19, 2016

@dahlia dahlia force-pushed the dahlia:docs branch from 9aaa2d4 to f9bb805 Jul 15, 2016

@dahlia dahlia force-pushed the dahlia:docs branch from f9bb805 to 052ae82 Jul 24, 2016

@dahlia dahlia force-pushed the dahlia:docs branch from 052ae82 to f4a4449 Aug 21, 2016

@dahlia dahlia force-pushed the dahlia:docs branch 2 times, most recently from e6ddd3a to eb3c973 Mar 7, 2017

@dahlia dahlia force-pushed the dahlia:docs branch from bf40e6a to b65e3fe Mar 11, 2017

@kanghyojun kanghyojun moved this from Chosen to In progress in Sprint at Jeju in March 2017 Mar 11, 2017

@AiOO AiOO self-assigned this Mar 11, 2017

@dahlia dahlia requested review from kanghyojun, yjroot, Kroisse and heejongahn Mar 11, 2017

@dahlia dahlia moved this from In progress to In review in Sprint at Jeju in March 2017 Mar 11, 2017

@dahlia dahlia changed the title WIP: Docs Docs Support Mar 11, 2017

@kanghyojun
Copy link
Member

left a comment

+1

@dahlia

This comment has been minimized.

Copy link
Member Author

commented Mar 12, 2017

@Kroisse @heejongahn 이 PR의 Travis CI 빌드를 보면, 아래와 같은 오류가 나고 있는데, 왜 src/Nirum/Targets/JavaScript.hs나 src/Nirum/CodeBuilder.hs 같은 파일들이 끼어 들어가 있을까요? 좀더 위쪽을 보면 빌드에서도 정작 저와 @AiOO가 추가한 src/Nirum/Targets/Docs.hs 파일은 없고 src/Nirum/Targets/JavaScript.hs만 포함되어 있습니다. 정황상으로는 PR #109의 빌드가 여기에 붙은 느낌인데요. (맥 빌드도 그렇고 리눅스 빌드도 그렇네요.) 짐작가는 게 있으신가요?

$ ./lint.sh
src/Nirum/Targets/JavaScript.hs:26:1: too long line (87 chars)
src/Nirum/Targets/JavaScript.hs:30:1: too long line (85 chars)
src/Nirum/Targets/JavaScript.hs:73:1: too long line (81 chars)
src/Nirum/Targets/JavaScript.hs:102:1: too long line (89 chars)
src/Nirum/Targets/JavaScript.hs:123:1: too long line (114 chars)
src/Nirum/Targets/JavaScript.hs:82:22: no space needed after {
src/Nirum/Targets/JavaScript.hs:82:25: no space needed before }
src/Nirum/Targets/JavaScript.hs:87:22: no space needed after {
src/Nirum/Targets/JavaScript.hs:87:25: no space needed before }
src/Nirum/Targets/JavaScript.hs:122:37: put blank after \
src/Nirum/CodeBuilder.hs:1:1: too long line (81 chars)
src/Nirum/CodeBuilder.hs:39:1: too long line (83 chars)
src/Nirum/CodeBuilder.hs:26:28: put blank after \
test/Nirum/Targets/JavaScriptSpec.hs:32:1: too long line (81 chars)
test/Nirum/Targets/JavaScriptSpec.hs:34:1: too long line (82 chars)
test/Nirum/Targets/JavaScriptSpec.hs:56:1: too long line (107 chars)
test/Nirum/CodeBuilderSpec.hs:24:47: put blank after \
@dahlia

This comment has been minimized.

Copy link
Member Author

commented Mar 12, 2017

정황상으로는 PR #109의 빌드가 여기에 붙은 느낌인데요.

@Kroisse @heejongahn @AiOO 로그를 보니 실제로 #109 PR의 내용을 체크아웃하고 있네요. 💦

$ git clone --depth=50 https://github.com/spoqa/nirum.git spoqa/nirum
Cloning into 'spoqa/nirum'...
remote: Counting objects: 1436, done.
remote: Compressing objects: 100% (529/529), done.
remote: Total 1436 (delta 829), reused 1400 (delta 801), pack-reused 0
Receiving objects: 100% (1436/1436), 300.61 KiB | 0 bytes/s, done.
Resolving deltas: 100% (829/829), done.

$ cd spoqa/nirum

$ git fetch origin +refs/pull/109/merge:
remote: Counting objects: 114, done.
remote: Compressing objects: 100% (73/73), done.
remote: Total 114 (delta 66), reused 87 (delta 41), pack-reused 0
Receiving objects: 100% (114/114), 14.66 KiB | 0 bytes/s, done.
Resolving deltas: 100% (66/66), completed with 10 local objects.
From https://github.com/spoqa/nirum
 * branch            refs/pull/109/merge -> FETCH_HEAD

$ git checkout -qf FETCH_HEAD
@dahlia

This comment has been minimized.

Copy link
Member Author

commented Mar 12, 2017

어제 Travis CI에 PR 빌드 관련 장애가 있었다고는 하는데, 혹시 모르니 리빌드 한번 돌려보겠습니다.

@dahlia

This comment has been minimized.

Copy link
Member Author

commented Mar 12, 2017

음, 리빌드를 돌려도 여전히 PR #109의 내용을 받아오네요. 해당 빌드는 일단 취소하고, 아예 amend해서 다시 푸시해보겠습니다.

@dahlia dahlia force-pushed the dahlia:docs branch from 19ccbf2 to a13fbe9 Mar 12, 2017

@dahlia

This comment has been minimized.

Copy link
Member Author

commented Mar 12, 2017

리베이스하고 다시 푸시했는데도 여전히 PR #109 내용을 받아오네요. 뭔가 오래된 PR이라 꼬인 것 같기도 해서 PR을 닫고 다시 올려보겠습니다.

@dahlia dahlia closed this Mar 12, 2017

@dahlia dahlia referenced this pull request Mar 12, 2017

@dahlia dahlia moved this from In review to Trash in Sprint at Jeju in March 2017 Mar 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.