Docs Support#10
Closed
dahlia wants to merge 14 commits into
Closed
Conversation
bf40e6a to
b65e3fe
Compare
Member
Author
|
@Kroisse @heejongahn 이 PR의 Travis CI 빌드를 보면, 아래와 같은 오류가 나고 있는데, 왜 src/Nirum/Targets/JavaScript.hs나 src/Nirum/CodeBuilder.hs 같은 파일들이 끼어 들어가 있을까요? 좀더 위쪽을 보면 빌드에서도 정작 저와 @AiOO가 추가한 src/Nirum/Targets/Docs.hs 파일은 없고 src/Nirum/Targets/JavaScript.hs만 포함되어 있습니다. 정황상으로는 PR #109의 빌드가 여기에 붙은 느낌인데요. (맥 빌드도 그렇고 리눅스 빌드도 그렇네요.) 짐작가는 게 있으신가요? |
Member
Author
@Kroisse @heejongahn @AiOO 로그를 보니 실제로 #109 PR의 내용을 체크아웃하고 있네요. 💦 |
Member
Author
|
어제 Travis CI에 PR 빌드 관련 장애가 있었다고는 하는데, 혹시 모르니 리빌드 한번 돌려보겠습니다. |
Member
Author
|
음, 리빌드를 돌려도 여전히 PR #109의 내용을 받아오네요. 해당 빌드는 일단 취소하고, 아예 amend해서 다시 푸시해보겠습니다. |
Member
Author
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although this branch is working in progress, I early open this pull request to share its progress.
The following is the list to do: