Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ancestors of packages to packages in setup.py #105

Merged
merged 8 commits into from Mar 8, 2017

Conversation

@AiOO
Copy link
Collaborator

commented Mar 7, 2017

This PR closes #92

@AiOO AiOO requested review from dahlia and Kroisse Mar 7, 2017

@AiOO AiOO force-pushed the AiOO:bugfix/add-ancestors-of-packages branch from 421c37a to 5317470 Mar 7, 2017

@AiOO AiOO moved this from Chosen to In review in Sprint at Jeju in March 2017 Mar 7, 2017

@AiOO AiOO requested a review from kanghyojun Mar 7, 2017

@dahlia
dahlia approved these changes Mar 7, 2017
@dahlia
Copy link
Member

left a comment

@AiOO Seems tests of generated Python code are broken. Try run tox on your local machine.

@dahlia dahlia added the typ:bug label Mar 7, 2017

@dahlia
dahlia approved these changes Mar 8, 2017

@dahlia dahlia merged commit 03c012d into nirum-lang:master Mar 8, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@AiOO

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 8, 2017

헐 머지 제가 하려고 했는데

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.