New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing `import typing` on Python 2 #117

Merged
merged 3 commits into from Mar 14, 2017

Conversation

Projects
None yet
2 participants
@dahlia
Member

dahlia commented Mar 14, 2017

There was a bug that Python 2 code generator had missed import typing even if some type expressions require it. This patch fixed the bug #93.

@dahlia dahlia added the typ:bug label Mar 14, 2017

@dahlia dahlia self-assigned this Mar 14, 2017

@dahlia dahlia requested a review from kanghyojun Mar 14, 2017

@kanghyojun

This comment has been minimized.

Member

kanghyojun commented Mar 14, 2017

approve

@dahlia dahlia merged commit 05c9a23 into nirum-lang:master Mar 14, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment