Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "minimum_runtime" option to Python target settings #119

Merged
merged 3 commits into from Mar 16, 2017

Conversation

dahlia
Copy link
Member

@dahlia dahlia commented Mar 14, 2017

This patch adds minimum_runtime option to Python target settings. The specified version goes to the generated install_requires list. Also the Nirum compiler now has its own minimum runtime version; see also Nirum.Targets.Python.minimumRuntime constant.

If minimum_runtime option specified by package.toml is older than compiler's minimum runtime version, or it's omitted, compiler's version is used instead.

Closes #118.

@dahlia dahlia added the typ:enhance label Mar 14, 2017
@dahlia dahlia self-assigned this Mar 14, 2017
@dahlia
Copy link
Member Author

@dahlia dahlia commented Mar 16, 2017

Though its build on macOS have been still failing (see also #115), as I tested it on my local macOS machine, I will merge this.

@dahlia dahlia merged commit 02ef704 into nirum-lang:master Mar 16, 2017
1 of 2 checks passed
@dahlia dahlia added cat:packaging cmp:compiler cmp:runtime target:python labels Aug 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:packaging cmp:compiler cmp:runtime target:python typ:enhance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants