Service methods should be possible to specify its error type #127
Merged
Conversation
dahlia
requested changes
Mar 23, 2017
| @@ -1,3 +1,5 @@ | |||
| @error("") | |||
Member
There was a problem hiding this comment.
Annotations don't have to have arguments (including parentheses). Therefore we can simplify this as @error. See also the parser code.
kanghyojun
changed the title
Member
Author
|
이제 남은 것은 Runtime쪽에서 |
dahlia
requested changes
Apr 1, 2017
dahlia
left a comment
dahlia
left a comment
Member
There was a problem hiding this comment.
@admire93 파일 중간에 패치 충돌한 흔적들이 보입니다.
Member
Author
|
@dahlia 리뷰를 부탁드립니다. |
dahlia
requested changes
Apr 20, 2017
| compileTypeDeclaration src | ||
| TypeDeclaration { typename = typename' | ||
| , type' = UnionType tags | ||
| , typeAnnotations = annotations } = do |
kanghyojun
force-pushed
the
throw-errors
branch
from
April 20, 2017 10:56
9647b9e to
146402d
Compare
dahlia
approved these changes
Apr 20, 2017
kanghyojun
force-pushed
the
throw-errors
branch
from
April 20, 2017 12:25
146402d to
16dff98
Compare
Member
Author
|
nirum-lang/nirum-python#71 is folloing issue. |
dahlia
added
cmp:compiler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#38