New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service methods should be possible to specify its error type #127

Merged
merged 3 commits into from Apr 20, 2017

Conversation

Projects
None yet
2 participants
@kanghyojun
Member

kanghyojun commented Mar 23, 2017

#38

@@ -1,3 +1,5 @@
@error("")

This comment has been minimized.

@dahlia

dahlia Mar 23, 2017

Member

Annotations don't have to have arguments (including parentheses). Therefore we can simplify this as @error. See also the parser code.

@kanghyojun kanghyojun force-pushed the kanghyojun:throw-errors branch from 3d494d0 to f930d5a Apr 1, 2017

@kanghyojun kanghyojun force-pushed the kanghyojun:throw-errors branch from f930d5a to 19e4d9e Apr 1, 2017

@kanghyojun kanghyojun changed the title from [WIP] Service methods should be possible to specify its error type to Service methods should be possible to specify its error type Apr 1, 2017

@kanghyojun

This comment has been minimized.

Member

kanghyojun commented Apr 1, 2017

이제 남은 것은 Runtime쪽에서 __nirum_method_error_types__를 잡아서 에러로 반환하도록 하는 정도입니다 리뷰 부탁드려요 @dahlia

@dahlia

@admire93 파일 중간에 패치 충돌한 흔적들이 보입니다.

@kanghyojun

This comment has been minimized.

Member

kanghyojun commented Apr 20, 2017

@dahlia 리뷰를 부탁드립니다.

compileTypeDeclaration src
TypeDeclaration { typename = typename'
, type' = UnionType tags
, typeAnnotations = annotations } = do

This comment has been minimized.

@dahlia

dahlia Apr 20, 2017

Member

닫는 중괄호를 여는 중괄호에 맞춰서 들여쓰기 부탁합니다.

@kanghyojun kanghyojun force-pushed the kanghyojun:throw-errors branch from 9647b9e to 146402d Apr 20, 2017

@dahlia

dahlia approved these changes Apr 20, 2017

@kanghyojun kanghyojun force-pushed the kanghyojun:throw-errors branch from 146402d to 16dff98 Apr 20, 2017

@kanghyojun kanghyojun merged commit 6b0223e into nirum-lang:master Apr 20, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kanghyojun kanghyojun self-assigned this Apr 20, 2017

@kanghyojun

This comment has been minimized.

Member

kanghyojun commented Apr 20, 2017

nirum-lang/nirum-python#71 is folloing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment