Add title to module document for Docs target #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahlia
requested changes
Mar 31, 2017
src/Nirum/Targets/Docs.hs
Outdated
| @@ -99,6 +100,8 @@ $case expr' | |||
| module' :: BoundModule Docs -> Html | |||
| module' docsModule = layout pkg path $ [shamlet| | |||
| <h1><code>#{path}</code> | |||
| $maybe tit <- title | |||
| <p>#{tit} | |||
There was a problem hiding this comment.
구두로도 얘기했지만, <h1> 뒤쪽에 나오면 좋을 것 같습니다.
src/Nirum/Targets/Docs.hs
Outdated
| title = | ||
| case mod' of | ||
| Just mod'' -> moduleTitle mod'' | ||
| _ -> Nothing |
There was a problem hiding this comment.
아마 hlint가 이미 오류를 냈을지도 모르겠는데… case … of … 표현식은 fmap moduleTitle mod' 정도로 줄일 수 있을 겁니다.
Prelude> fmap (+1) (Just 123)
Just 124
Prelude> fmap (+1) Nothing
Nothing
kanghyojun
reviewed
Apr 1, 2017
src/Nirum/Targets/Docs.hs
Outdated
| title :: Maybe Html | ||
| title = | ||
| case mod' of | ||
| Just mod'' -> moduleTitle mod'' |
There was a problem hiding this comment.
ㅋㅋㅋ 차라리 foundModule 같은 이름은 어떨까요?
There was a problem hiding this comment.
@admire93 결과가 모듈 제목이라 지금 이름이 더 나은 것 같읍니다.
dahlia
approved these changes
Apr 12, 2017
dahlia
added
the
cmp:compiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
related #125