New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make generated Python codes refactored for new transport layer #149

Merged
merged 5 commits into from Jul 11, 2017

Conversation

Projects
None yet
2 participants
@dahlia
Member

dahlia commented Jul 10, 2017

This compiler patch is for suggested new transport layer nirum-lang/nirum-python#79 and related other things. It also is required by another patch on nirum-python nirum-lang/nirum-python#92 and need to be merged first.

Key changes:

  • Generated constructors of service clients became to take a nirum.transport.Transport instance.
  • Followed renamed/moved import paths of the runtime classes (e.g. nirum.rpc.Servicenirum.service.Service).
  • The way to avoid name collision between generated types and runtime classes is changed. The runtime library had provided alternative names like service_type for Service and generated imports had been like from nirum.rpc import service_type, but it's now from nirum.service import Service as service_type.

As its build requires transport features made by nirum-lang/nirum-python#92 (which is not merged yet) and two patches have a circular dependency each other, I temporarily switched the CI scripts to use DEVRUNTIME_REPO=dahlia/nirum-python DEVRUNTIME_REF=transport.

@dahlia dahlia added the typ:enhance label Jul 10, 2017

@dahlia dahlia self-assigned this Jul 10, 2017

@dahlia dahlia requested a review from kanghyojun Jul 10, 2017

@dahlia dahlia force-pushed the dahlia:transport branch from 955e4f5 to 581e56e Jul 10, 2017

@kanghyojun

This comment has been minimized.

Member

kanghyojun commented Jul 11, 2017

윈도우에서 깨지네요.

@dahlia dahlia force-pushed the dahlia:transport branch from 581e56e to aacdfa1 Jul 11, 2017

@dahlia dahlia merged commit fe068c6 into nirum-lang:master Jul 11, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment