New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy binary to PATH #155

Merged
merged 1 commit into from Jul 25, 2017

Conversation

Projects
None yet
3 participants
@kanghyojun
Member

kanghyojun commented Jul 25, 2017

nirum couldn't be executed because nirum binary didn't be placed on
PATH. so i added --copy-bins option to copy binary into PATH

@dahlia @Kroisse @AiOO @ipdae help me!

Copy binary to PATH
`nirum` couldn't be executed because nirum binary didn't be placed on
`PATH`. so use `--copy-bins` option to copy binary into `PATH`

@kanghyojun kanghyojun added the typ:bug label Jul 25, 2017

@kanghyojun kanghyojun self-assigned this Jul 25, 2017

@kanghyojun kanghyojun requested review from dahlia, Kroisse, AiOO and ipdae Jul 25, 2017

@Kroisse

하는 김에 테스트에서 Docker 이미지로 니름 실행해보는 스텝도 추가하면 어떨까요

@dahlia

This comment has been minimized.

Member

dahlia commented Jul 25, 2017

하는 김에 테스트에서 Docker 이미지로 니름 실행해보는 스텝도 추가하면 어떨까요

@Kroisse 좋은 생각인데 현재는 Docker Hub에서 제공하는 automated build로 굽고 있어서 Travis CI에서 테스트하기에는 순서가 애매하긴 할 것 같아요.

@dahlia

dahlia approved these changes Jul 25, 2017

@kanghyojun

This comment has been minimized.

Member

kanghyojun commented Jul 25, 2017

아.. 그래서 도커허브에 올리는 부분이 안보였군요ㅜㅜ 일단 이건 머지하고 도커이미지로 테스트하는건 따로 해보겠습니다.

@kanghyojun kanghyojun merged commit fc16709 into nirum-lang:master Jul 25, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Kroisse

This comment has been minimized.

Contributor

Kroisse commented Jul 25, 2017

넵넵

@dahlia dahlia added the cat:dist label Aug 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment