Defaulting None for optional fields #165
Merged
Conversation
|
@earlbread Generally it looks good to me. |
| int64? price, | ||
| bool sale, | ||
| uri? url, | ||
| ); |
dahlia
Aug 15, 2017
Member
We should test union tags as well e.g.:
union union-test = tag-a
| tag-b (text a, text? b, int64 c, int64 d?);
We should test union tags as well e.g.:
union union-test = tag-a
| tag-b (text a, text? b, int64 c, int64 d?);
test/python/primitive_test.py
Outdated
| def test_optional_initializer_test(): | ||
| product = Product(name=u'coffee', sale=False) | ||
| assert product.price is None | ||
| assert product.url is None |
dahlia
Aug 15, 2017
Member
We should test union tags as well e.g.:
def test_union_tags_optional_initializer():
t = TagB(a=u'test', c=123)
assert t.a == u'test'
assert t.b is None
assert t.c == 123
assert t.d is None
We should test union tags as well e.g.:
def test_union_tags_optional_initializer():
t = TagB(a=u'test', c=123)
assert t.a == u'test'
assert t.b is None
assert t.c == 123
assert t.d is None
test/python/primitive_test.py
Outdated
| @@ -249,3 +249,9 @@ def test_service(): | |||
| PingService().ping(nonce=u'nonce') | |||
| with raises(TypeError): | |||
| PingService().ping(wrongkwd=u'a') | |||
|
|
|||
|
|
|||
| def test_optional_initializer_test(): | |||
dahlia
Aug 15, 2017
Member
Since the function name already starts with test_ we need no _test suffix here.
Since the function name already starts with test_ we need no _test suffix here.
|
@dahlia I fixed things you mentioned. Thank you! |
|
Everything looks good to me. |
dahlia
added a commit
to nirum-lang/nirum-python
that referenced
this pull request
Oct 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This fixes #70.