Skip to content

Improve document design - #170

Merged
dahlia merged 1 commit into
nirum-lang:masterfrom
AiOO:improve/make-document-complete-again
Aug 17, 2017
Merged

Improve document design#170
dahlia merged 1 commit into
nirum-lang:masterfrom
AiOO:improve/make-document-complete-again

Conversation

@AiOO

@AiOO AiOO commented Aug 15, 2017

Copy link
Copy Markdown
Collaborator

TBD 👶

@dahlia

dahlia commented Aug 15, 2017

Copy link
Copy Markdown
Member

@AiOO hlint seems unsatisfied:

src/Nirum/Targets/Docs.hs:351:51: Suggestion: Redundant $

Found:

  TL.toStrict $ stylesheet

Why not:

  TL.toStrict stylesheet

@dahlia
dahlia self-requested a review August 15, 2017 11:43
@dahlia dahlia added cat:docs Category: Documentation typ:enhance Type: Enhancement/new feature labels Aug 15, 2017
@AiOO
AiOO force-pushed the improve/make-document-complete-again branch from 8c70ee9 to df54d21 Compare August 17, 2017 00:44

@dahlia dahlia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dahlia
dahlia merged commit fe905b8 into nirum-lang:master Aug 17, 2017
@kanghyojun

Copy link
Copy Markdown
Member

ㅋㅋㅋㅋㅋㅋㅋ

@AiOO

AiOO commented Aug 17, 2017

Copy link
Copy Markdown
Collaborator Author

TB..D..... 😢

@dahlia dahlia added the cmp:compiler Component: Compiler backend (e.g., annotation processors, code generators) label Aug 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cat:docs Category: Documentation cmp:compiler Component: Compiler backend (e.g., annotation processors, code generators) typ:enhance Type: Enhancement/new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants