Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve document design #170

Merged
merged 1 commit into from Aug 17, 2017

Conversation

@AiOO
Copy link
Collaborator

@AiOO AiOO commented Aug 15, 2017

TBD 馃懚

@dahlia
Copy link
Member

@dahlia dahlia commented Aug 15, 2017

@AiOO hlint seems unsatisfied:

src/Nirum/Targets/Docs.hs:351:51: Suggestion: Redundant $

Found:

  TL.toStrict $ stylesheet

Why not:

  TL.toStrict stylesheet
@AiOO AiOO force-pushed the AiOO:improve/make-document-complete-again branch from 8c70ee9 to df54d21 Aug 17, 2017
@dahlia
dahlia approved these changes Aug 17, 2017
Copy link
Member

@dahlia dahlia left a comment

LGTM

@dahlia dahlia merged commit fe905b8 into nirum-lang:master Aug 17, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kanghyojun
Copy link
Member

@kanghyojun kanghyojun commented Aug 17, 2017

銋嬨厠銋嬨厠銋嬨厠銋

@AiOO
Copy link
Collaborator Author

@AiOO AiOO commented Aug 17, 2017

TB..D..... 馃槩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants