Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license field to package metadata #180

Merged
merged 4 commits into from
Aug 30, 2017

Conversation

earlbread
Copy link
Contributor

This patch adds the license field to package metadata. (#100)

Copy link
Member

@dahlia dahlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@earlbread Generally looks good for me. Could you adjust just one style thing? 😋

@@ -96,11 +97,12 @@ deriving instance (Ord t, Target t) => Ord (Package t)
deriving instance (Show t, Target t) => Show (Package t)

packageTarget :: Target t => Package t -> t
packageTarget Package { metadata = Metadata _ _ _ t } = t
packageTarget Package { metadata = Metadata _ _ _ _ t } = t
Copy link
Member

@dahlia dahlia Aug 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Metadata gets having many fields, we'd better use record syntax:

packageTarget Package { metadata = Metadata { target = t } } = t

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you, I'll fix it soon. Thank you!

@dahlia dahlia mentioned this pull request Aug 29, 2017
4 tasks
@dahlia dahlia added cat:packaging Category: Nirum schema packaging (not compiler packaging) cmp:compiler Component: Compiler backend (e.g., annotation processors, code generators) target:python typ:enhance Type: Enhancement/new feature labels Aug 29, 2017
@dahlia
Copy link
Member

dahlia commented Aug 29, 2017

Although builds were failed, it's not caused by this patch. These failures have occasionally happened, so never mind.

@earlbread
Copy link
Contributor Author

I updated the code using record syntax.

Copy link
Member

@dahlia dahlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@earlbread Everything seems perfect. 👍 Only remaining thing to do is just waiting for builds. 😄

@dahlia dahlia merged commit c190847 into nirum-lang:master Aug 30, 2017
@dahlia
Copy link
Member

dahlia commented Aug 30, 2017

@earlbread Thanks for your contribution. 😄 Just merged!

@earlbread
Copy link
Contributor Author

@dahlia Thank you!

@earlbread earlbread deleted the add_license_metadata branch August 30, 2017 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:packaging Category: Nirum schema packaging (not compiler packaging) cmp:compiler Component: Compiler backend (e.g., annotation processors, code generators) target:python typ:enhance Type: Enhancement/new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants