Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license field to package metadata #180

Merged
merged 4 commits into from Aug 30, 2017

Conversation

@earlbread
Copy link
Contributor

@earlbread earlbread commented Aug 29, 2017

This patch adds the license field to package metadata. (#100)

Copy link
Member

@dahlia dahlia left a comment

@earlbread Generally looks good for me. Could you adjust just one style thing? 😋

@@ -96,11 +97,12 @@ deriving instance (Ord t, Target t) => Ord (Package t)
deriving instance (Show t, Target t) => Show (Package t)

packageTarget :: Target t => Package t -> t
packageTarget Package { metadata = Metadata _ _ _ t } = t
packageTarget Package { metadata = Metadata _ _ _ _ t } = t

This comment has been minimized.

@dahlia

dahlia Aug 29, 2017
Member

As Metadata gets having many fields, we'd better use record syntax:

packageTarget Package { metadata = Metadata { target = t } } = t

This comment has been minimized.

@earlbread

earlbread Aug 29, 2017
Author Contributor

I agree with you, I'll fix it soon. Thank you!

@dahlia
Copy link
Member

@dahlia dahlia commented Aug 29, 2017

Although builds were failed, it's not caused by this patch. These failures have occasionally happened, so never mind.

@earlbread
Copy link
Contributor Author

@earlbread earlbread commented Aug 29, 2017

I updated the code using record syntax.

@dahlia
dahlia approved these changes Aug 29, 2017
Copy link
Member

@dahlia dahlia left a comment

@earlbread Everything seems perfect. 👍 Only remaining thing to do is just waiting for builds. 😄

@dahlia dahlia merged commit c190847 into nirum-lang:master Aug 30, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dahlia
Copy link
Member

@dahlia dahlia commented Aug 30, 2017

@earlbread Thanks for your contribution. 😄 Just merged!

@earlbread
Copy link
Contributor Author

@earlbread earlbread commented Aug 30, 2017

@dahlia Thank you!

@earlbread earlbread deleted the earlbread:add_license_metadata branch Aug 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants