Add license field to package metadata #180
Merged
Conversation
|
@earlbread Generally looks good for me. Could you adjust just one style thing? |
src/Nirum/Package/Metadata.hs
Outdated
| @@ -96,11 +97,12 @@ deriving instance (Ord t, Target t) => Ord (Package t) | |||
| deriving instance (Show t, Target t) => Show (Package t) | |||
|
|
|||
| packageTarget :: Target t => Package t -> t | |||
| packageTarget Package { metadata = Metadata _ _ _ t } = t | |||
| packageTarget Package { metadata = Metadata _ _ _ _ t } = t | |||
dahlia
Aug 29, 2017
•
Member
As Metadata gets having many fields, we'd better use record syntax:
packageTarget Package { metadata = Metadata { target = t } } = t
As Metadata gets having many fields, we'd better use record syntax:
packageTarget Package { metadata = Metadata { target = t } } = t
earlbread
Aug 29, 2017
Author
Contributor
I agree with you, I'll fix it soon. Thank you!
I agree with you, I'll fix it soon. Thank you!
Closed
|
Although builds were failed, it's not caused by this patch. These failures have occasionally happened, so never mind. |
|
I updated the code using record syntax. |
|
@earlbread Everything seems perfect. |
|
@earlbread Thanks for your contribution. |
|
@dahlia Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This patch adds the license field to package metadata. (#100)