Add license field to package metadata #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahlia
requested changes
Aug 29, 2017
Member
dahlia
left a comment
dahlia
left a comment
There was a problem hiding this comment.
@earlbread Generally looks good for me. Could you adjust just one style thing? 😋
src/Nirum/Package/Metadata.hs
Outdated
|
|
||
| packageTarget :: Target t => Package t -> t | ||
| packageTarget Package { metadata = Metadata _ _ _ t } = t | ||
| packageTarget Package { metadata = Metadata _ _ _ _ t } = t |
Member
There was a problem hiding this comment.
As Metadata gets having many fields, we'd better use record syntax:
packageTarget Package { metadata = Metadata { target = t } } = t
Contributor
Author
There was a problem hiding this comment.
I agree with you, I'll fix it soon. Thank you!
dahlia
added
cat:packaging
Member
|
Although builds were failed, it's not caused by this patch. These failures have occasionally happened, so never mind. |
Contributor
Author
|
I updated the code using record syntax. |
dahlia
approved these changes
Aug 29, 2017
Member
dahlia
left a comment
dahlia
left a comment
There was a problem hiding this comment.
@earlbread Everything seems perfect. 👍 Only remaining thing to do is just waiting for builds. 😄
Member
|
@earlbread Thanks for your contribution. 😄 Just merged! |
Contributor
Author
|
@dahlia Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the license field to package metadata. (#100)