Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd license field to package metadata #180
Conversation
earlbread
added some commits
Aug 29, 2017
dahlia
requested changes
Aug 29, 2017
@earlbread Generally looks good for me. Could you adjust just one style thing?
src/Nirum/Package/Metadata.hs
Outdated
| @@ -96,11 +97,12 @@ deriving instance (Ord t, Target t) => Ord (Package t) | |||
| deriving instance (Show t, Target t) => Show (Package t) | |||
|
|
|||
| packageTarget :: Target t => Package t -> t | |||
| packageTarget Package { metadata = Metadata _ _ _ t } = t | |||
| packageTarget Package { metadata = Metadata _ _ _ _ t } = t | |||
This comment has been minimized.
This comment has been minimized.
dahlia
Aug 29, 2017
•
Member
As Metadata gets having many fields, we'd better use record syntax:
packageTarget Package { metadata = Metadata { target = t } } = t
This comment has been minimized.
This comment has been minimized.
dahlia
added
cat:packaging
cmp:compiler
target:python
typ:enhance
labels
Aug 29, 2017
This comment has been minimized.
This comment has been minimized.
|
Although builds were failed, it's not caused by this patch. These failures have occasionally happened, so never mind. |
This comment has been minimized.
This comment has been minimized.
|
I updated the code using record syntax. |
dahlia
approved these changes
Aug 29, 2017
@earlbread Everything seems perfect.
dahlia
merged commit c190847
into
nirum-lang:master
Aug 30, 2017
This comment has been minimized.
This comment has been minimized.
|
@earlbread Thanks for your contribution. |
This comment has been minimized.
This comment has been minimized.
|
@dahlia Thank you! |
earlbread
deleted the
earlbread:add_license_metadata
branch
Aug 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
earlbread commentedAug 29, 2017
This patch adds the license field to package metadata. (#100)