Add keywords field to package metadata#183
Merged
Merged
Conversation
dahlia
requested changes
Sep 22, 2017
Member
dahlia
left a comment
There was a problem hiding this comment.
An array of strings (e.g. ["sample", "example", "nirum"]) would be better than a string for keywords.
I named keywords metadata to
packageKeywordsbecause of a conflict with Python keywords inNirum/Targets/Python.hs.
We can resolve a conflict of names without choose a different name. Qualified import is enough:
import qualified Nirum.Package.Metadata as MD
pKeywords :: Code
pKeywords = fromMaybeToMeta $ MD.keywords metadata'
Contributor
Author
|
@dahlia Thanks for the advice. I'll fix it soon! |
Contributor
Author
|
@dahlia I changed keywords metadata to an array. Thank you! |
dahlia
approved these changes
Oct 18, 2017
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds the keywords field to package metadata. (#100)
I named keywords metadata to
packageKeywordsbecause of a conflict with Python keywords inNirum/Targets/Python.hs.