New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keywords field to package metadata #183

Merged
merged 3 commits into from Oct 18, 2017

Conversation

Projects
None yet
2 participants
@earlbread
Contributor

earlbread commented Sep 19, 2017

This patch adds the keywords field to package metadata. (#100)

I named keywords metadata to packageKeywords because of a conflict with Python keywords in Nirum/Targets/Python.hs.

@dahlia

An array of strings (e.g. ["sample", "example", "nirum"]) would be better than a string for keywords.

I named keywords metadata to packageKeywords because of a conflict with Python keywords in Nirum/Targets/Python.hs.

We can resolve a conflict of names without choose a different name. Qualified import is enough:

import qualified Nirum.Package.Metadata as MD

pKeywords :: Code
pKeywords = fromMaybeToMeta $ MD.keywords metadata'
@earlbread

This comment has been minimized.

Contributor

earlbread commented Sep 23, 2017

@dahlia Thanks for the advice. I'll fix it soon!

@earlbread

This comment has been minimized.

Contributor

earlbread commented Oct 17, 2017

@dahlia I changed keywords metadata to an array. Thank you!

@dahlia

dahlia approved these changes Oct 18, 2017

@dahlia dahlia merged commit 68542b7 into nirum-lang:master Oct 18, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@dahlia

This comment has been minimized.

Member

dahlia commented Oct 18, 2017

Thanks!

@earlbread earlbread deleted the earlbread:add_keywords_metadata branch Oct 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment