Repository navigation
Compile service method annotation - #194
Merged
kanghyojun merged 4 commits intoNov 15, 2017
Merged
Conversation
hanc1208
reviewed
Nov 10, 2017
| # FIXME Give annotations. | ||
| service_annotations=\{\}, | ||
| method_annotations=\{\}, | ||
| method_annotations=\{\} |
kanghyojun
force-pushed
the
compile-method-annotation
branch
from
November 12, 2017 09:11
fba3b8a to
85371f9
Compare
kanghyojun
changed the title
Member
Author
kanghyojun
added
cmp:compiler
dahlia
previously approved these changes
Nov 12, 2017
dahlia
left a comment
dahlia
left a comment
Member
There was a problem hiding this comment.
리뷰로 남긴 제안들은 지금 당장 안 해도 되긴 합니다.
| ] | ||
| methodAnnotations' :: T.Text | ||
| methodAnnotations' = wrapMap $ commaNl $ map compileMethodAnnotation | ||
| methodList |
Member
There was a problem hiding this comment.
결국 나중에 레코드나 유니온 클래스도 이런 애너테이션 메타데이터를 생성해줘야 하기 때문에, 이 코드들이 조만간 일반화되어서 where절 바깥으로 나가야 할 것 같네요. 미리 그렇게 해둘 필요는 없긴 합니다.
아예 Nirum.Targets.Python.Annotation, Nirum.Targets.Python.Name 뭐 이런 식으로 파이썬 타겟 내부에서 쓰이는 유틸리티 함수를 하위 모듈로 보내는 것도 한 방법일 것 같네요. 줄 자체가 너무 길어져서…
kanghyojun
force-pushed
the
compile-method-annotation
branch
from
November 12, 2017 09:32
c1c9e62 to
18a72d5
Compare
dahlia
previously approved these changes
Nov 12, 2017
Print method annotations into __nirum_method_annotations__
kanghyojun
force-pushed
the
compile-method-annotation
branch
from
November 14, 2017 04:06
18a72d5 to
2b7c1e2
Compare
Member
Author
|
@dahlia 리베이스했습니다. 한번만더 리뷰 부탁드려요. |
dahlia
approved these changes
Nov 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we need metadata of annotations on service class to route HTTP paths, i added
__nirum_method_annotations__property.__nirum_method_annotations__contain metadata of method annotations as nirum.datastaructures.Map type because it have to be immutable data.