New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make annotation argument values able to contain Unicode characters #197

merged 1 commit into from Nov 27, 2017


None yet
2 participants

dahlia commented Nov 24, 2017

Unlike annotation names or annotation parameter names, annotation argument values should be able to contain non-ASCII Unicode characters. This fixes the Python target to correctly translate annotation argument values to Unicode string literals instead of byte string literals.

@dahlia dahlia self-assigned this Nov 24, 2017

@dahlia dahlia requested a review from kanghyojun Nov 24, 2017

@kanghyojun kanghyojun merged commit 69de225 into nirum-lang:master Nov 27, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

dahlia added a commit to kanghyojun/nirum-python-wsgi that referenced this pull request Nov 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment