New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make import names can have a trailing comma and be multiline #202

Merged
merged 1 commit into from Dec 11, 2017

Conversation

Projects
None yet
2 participants
@dahlia
Member

dahlia commented Dec 10, 2017

This patch makes the parser accepts import names with a trailing comma or in multilines that hadn't been allowed, e.g.:

import foo.baz (
    c,
    d,
);

@dahlia dahlia self-assigned this Dec 10, 2017

@dahlia dahlia requested a review from kanghyojun Dec 10, 2017

@kanghyojun

빌드는 실패했네요. 아마 맥빌드 아닌지..

@dahlia dahlia force-pushed the dahlia:freer-import-names branch from bbe0b3e to c649c94 Dec 10, 2017

@kanghyojun

This comment has been minimized.

Member

kanghyojun commented Dec 11, 2017

Approved

@dahlia dahlia merged commit b9f6dd8 into nirum-lang:master Dec 11, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment