Skip to content

Make import names can have a trailing comma and be multiline #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dahlia merged 1 commit into from
Dec 11, 2017
Merged

Make import names can have a trailing comma and be multiline #202

dahlia merged 1 commit into from
Dec 11, 2017

Conversation

@dahlia
Copy link
Member

@dahlia dahlia commented Dec 10, 2017

This patch makes the parser accepts import names with a trailing comma or in multilines that hadn't been allowed, e.g.:

import foo.baz (
    c,
    d,
);

@dahlia dahlia added cat:lang Category: Language design cmp:frontend Component: Compiler frontend (e.g., CLI, parser, AST) typ:bug Type: Bug/defect labels Dec 10, 2017
@dahlia dahlia self-assigned this Dec 10, 2017
@dahlia dahlia requested a review from kanghyojun December 10, 2017 16:02
kanghyojun
kanghyojun previously approved these changes Dec 10, 2017
View reviewed changes
Copy link
Member

@kanghyojun kanghyojun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빌드는 실패했네요. 아마 맥빌드 아닌지..

@dahlia dahlia force-pushed the freer-import-names branch from bbe0b3e to c649c94 Compare December 10, 2017 17:26
@kanghyojun
Copy link
Member

kanghyojun commented Dec 11, 2017

Approved

@dahlia dahlia merged commit b9f6dd8 into nirum-lang:master Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kanghyojun kanghyojun kanghyojun approved these changes

Assignees

@dahlia dahlia

Labels

cat:lang Category: Language design cmp:frontend Component: Compiler frontend (e.g., CLI, parser, AST) typ:bug Type: Bug/defect

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dahlia @kanghyojun