New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#167: Add Client class under Service class #222

Merged
merged 1 commit into from Feb 10, 2018

Conversation

Projects
3 participants
@qria
Contributor

qria commented Feb 9, 2018

Fixes #167

@kanghyojun kanghyojun requested review from dahlia and kanghyojun Feb 9, 2018

@kanghyojun kanghyojun self-assigned this Feb 9, 2018

@qria qria force-pushed the qria:issue-167 branch from a850129 to 5383046 Feb 9, 2018

@dahlia dahlia added this to In progress in Sprint at Seoul in February 2018 Feb 9, 2018

@qria qria force-pushed the qria:issue-167 branch from 5383046 to 9f2c36d Feb 9, 2018

if hasattr({className}.Client, '__qualname__'):
{className}.Client.__qualname__ = '{className}.Client'
else:
{className}.Client.__name__ = '{className}.Client'

This comment has been minimized.

@dahlia

dahlia Feb 9, 2018

Member

이건 안 해주셔도 될 것 같습니다. 어차피 파이썬 2에서 inner class에 대해서 이런 걸 해주지 않아서…

그냥 파이썬 2에서도 __qualname__ 세팅해주면 될 것 같습니다. 파이썬 2에서는 있어도 무시하기 때문에 어떻게 하든 같은 거라서요.


def test_service_client_representation():
assert repr(SampleService.Client) == \
"<class 'fixture.foo.SampleService.Client'>"

This comment has been minimized.

@dahlia

dahlia Feb 9, 2018

Member

이거 진짜 그냥 __qualname__만 검사해도 될 것 같아요.

@qria qria force-pushed the qria:issue-167 branch from 9f2c36d to 5893d55 Feb 9, 2018

@qria

This comment has been minimized.

Contributor

qria commented Feb 9, 2018

@dahlia 반0하였습니다

if hasattr({className}.Client, '__qualname__'):
{className}.Client.__qualname__ = '{className}.Client'
else:
{className}.Client.__name__ = 'Client'

This comment has been minimized.

@dahlia

dahlia Feb 9, 2018

Member

파이썬 3에서도 __name__'Client'여야 하지 않을까요?

This comment has been minimized.

@qria

qria Feb 10, 2018

Contributor

반영하였습니다.

@qria qria force-pushed the qria:issue-167 branch from 5893d55 to 6d5463d Feb 10, 2018

@dahlia dahlia assigned qria and unassigned kanghyojun Feb 10, 2018

@dahlia

dahlia approved these changes Feb 10, 2018

@dahlia dahlia merged commit f606f05 into nirum-lang:master Feb 10, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Sprint at Seoul in February 2018 automation moved this from In progress to Delivered Feb 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment