Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

targets.docs.title config to render <title> #253

Merged
merged 4 commits into from Mar 27, 2018
Merged

Conversation

@dahlia
Copy link
Member

@dahlia dahlia commented Mar 22, 2018

In order to render a meaningful <title>, a new required configuration targets.docs.title was added.

[targets.python]
name = "nirum_fixture"
[targets.python.renames]
"renames.test" = "renamed"

[targets.docs]
title = "Fixtures for Nirum tests"
Copy link
Collaborator

@AiOO AiOO Mar 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스트에서 검사하면 좋지 않을까요 핳ㅎ.ㅏ...

Loading

Copy link
Member Author

@dahlia dahlia Mar 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AiOO 테스트 붙였습니다. b581a84

Loading

@codecov
Copy link

@codecov codecov bot commented Mar 23, 2018

Codecov Report

Merging #253 into master will increase coverage by 2.17%.
The diff coverage is 70%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #253      +/-   ##
=========================================
+ Coverage   73.13%   75.3%   +2.17%     
=========================================
  Files          33      33              
  Lines        2356    2361       +5     
  Branches      130     136       +6     
=========================================
+ Hits         1723    1778      +55     
+ Misses        503     447      -56     
- Partials      130     136       +6
Impacted Files Coverage Δ
src/Nirum/Targets/Docs.hs 67.85% <70%> (+51.4%) ⬆️
src/Nirum/Package.hs 86.04% <0%> (+2.32%) ⬆️
src/Nirum/Package/Metadata.hs 79.57% <0%> (+7.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4529e07...748531f. Read the comment docs.

Loading

@dahlia
Copy link
Member Author

@dahlia dahlia commented Mar 23, 2018

@admire93 @AiOO I rebased it on the current master, added some tests, and wrote docs about docs target.

Loading

AiOO
AiOO approved these changes Mar 27, 2018
@dahlia dahlia merged commit 748531f into nirum-lang:master Mar 27, 2018
3 of 4 checks passed
Loading
dahlia added a commit that referenced this issue Mar 27, 2018
targets.docs.title config to render <title>
@dahlia dahlia added this to the Version 0.4.0 milestone May 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants