Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

targets.docs.title config to render <title> #253

Merged
merged 4 commits into from Mar 27, 2018

Conversation

@dahlia
Copy link
Member

commented Mar 22, 2018

In order to render a meaningful <title>, a new required configuration targets.docs.title was added.

@dahlia dahlia self-assigned this Mar 22, 2018

@dahlia dahlia requested review from kanghyojun and AiOO Mar 22, 2018

[targets.python]
name = "nirum_fixture"
[targets.python.renames]
"renames.test" = "renamed"

[targets.docs]
title = "Fixtures for Nirum tests"

This comment has been minimized.

Copy link
@AiOO

AiOO Mar 23, 2018

Collaborator

테스트에서 검사하면 좋지 않을까요 핳ㅎ.ㅏ...

This comment has been minimized.

Copy link
@dahlia

dahlia Mar 23, 2018

Author Member

@AiOO 테스트 붙였습니다. b581a84

@dahlia dahlia force-pushed the dahlia:docs-title branch from 89885c2 to a5cf62d Mar 23, 2018

dahlia added a commit to dahlia/nirum that referenced this pull request Mar 23, 2018
@codecov

This comment has been minimized.

Copy link

commented Mar 23, 2018

Codecov Report

Merging #253 into master will increase coverage by 2.17%.
The diff coverage is 70%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #253      +/-   ##
=========================================
+ Coverage   73.13%   75.3%   +2.17%     
=========================================
  Files          33      33              
  Lines        2356    2361       +5     
  Branches      130     136       +6     
=========================================
+ Hits         1723    1778      +55     
+ Misses        503     447      -56     
- Partials      130     136       +6
Impacted Files Coverage Δ
src/Nirum/Targets/Docs.hs 67.85% <70%> (+51.4%) ⬆️
src/Nirum/Package.hs 86.04% <0%> (+2.32%) ⬆️
src/Nirum/Package/Metadata.hs 79.57% <0%> (+7.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4529e07...748531f. Read the comment docs.

@dahlia

This comment has been minimized.

Copy link
Member Author

commented Mar 23, 2018

@admire93 @AiOO I rebased it on the current master, added some tests, and wrote docs about docs target.

@dahlia dahlia force-pushed the dahlia:docs-title branch from a5cf62d to 741ab2d Mar 26, 2018

Hong Minhee
@AiOO
AiOO approved these changes Mar 27, 2018

@dahlia dahlia merged commit 748531f into nirum-lang:master Mar 27, 2018

3 of 4 checks passed

codecov/patch 70% of diff hit (target 73.13%)
Details
codecov/project 75.3% (+2.17%) compared to fae1791
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dahlia added a commit that referenced this pull request Mar 27, 2018
Merge pull request #253 from dahlia/docs-title
targets.docs.title config to render <title>

@dahlia dahlia added this to the Version 0.4.0 milestone May 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.