New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make enum members and union tags to reserve top-level type namespace #254

Merged
merged 1 commit into from Mar 26, 2018

Conversation

Projects
None yet
2 participants
@dahlia
Member

dahlia commented Mar 25, 2018

In order to make Nirum IDL more portable to various target languages, I added some more rules to restrict name shadowing. See also changelog I wrote.

@dahlia dahlia self-assigned this Mar 25, 2018

@dahlia dahlia requested a review from kanghyojun Mar 25, 2018

@codecov

This comment has been minimized.

codecov bot commented Mar 25, 2018

Codecov Report

Merging #254 into master will increase coverage by 0.17%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #254      +/-   ##
==========================================
+ Coverage   72.96%   73.13%   +0.17%     
==========================================
  Files          33       33              
  Lines        2341     2356      +15     
  Branches      130      130              
==========================================
+ Hits         1708     1723      +15     
  Misses        503      503              
  Partials      130      130
Impacted Files Coverage Δ
src/Nirum/Constructs/Declaration.hs 100% <100%> (ø) ⬆️
src/Nirum/Constructs/DeclarationSet.hs 83.92% <100%> (+3.49%) ⬆️
src/Nirum/Constructs/TypeDeclaration.hs 77.85% <100%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e6b00a...fae1791. Read the comment docs.

@dahlia dahlia merged commit 4529e07 into nirum-lang:master Mar 26, 2018

4 checks passed

codecov/patch 100% of diff hit (target 72.96%)
Details
codecov/project 73.13% (+0.17%) compared to ba9d43b
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dahlia dahlia added this to the Version 0.4.0 milestone May 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment