Nicer error message on name duplicates #255
Merged
Conversation
Checklist
|
Codecov Report
@@ Coverage Diff @@
## master #255 +/- ##
==========================================
+ Coverage 73.13% 73.77% +0.64%
==========================================
Files 33 33
Lines 2356 2391 +35
Branches 130 124 -6
==========================================
+ Hits 1723 1764 +41
Misses 503 503
+ Partials 130 124 -6
Continue to review full report at Codecov.
|
dahlia
added a commit
that referenced
this pull request
Mar 27, 2018
Nicer error message on name duplicates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Continued from #254. Now give nicer error message on name duplicates. Offset line/column number became accurate.
Where the following Nirum code is given:
Although the compiler had given the following error message (which refers to inaccurate offset line/column number):
It's now like the following:
See also the added
"handling name duplications"
test case.