New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several improvements on docs target #259

Merged
merged 4 commits into from Apr 15, 2018

Conversation

Projects
None yet
3 participants
@dahlia
Member

dahlia commented Apr 12, 2018

  • 7ac8e65: Added the missing module-level docs.
  • f0c3e30: Show which tag (if exists) of a union is default. The default keyword on tags is a recently added feature; see also #227 and #13.
  • 85aedff: Adjusted on HTML markups; it's about styles and semantics.
  • dc13fd9: Require the latest tox version to avoid recent breakage on Python 2.7 builds. (I guess it's related to the migration from https://pypi.python.org/ to https://pypi.org/ but am not sure.)

@dahlia dahlia self-assigned this Apr 12, 2018

@dahlia dahlia requested review from kanghyojun and AiOO Apr 12, 2018

@checkmate-bot

This comment has been minimized.

checkmate-bot commented Apr 12, 2018

Checklist 🤔

tox.ini

  • When the list of supported Python versions change, synchronize the change with .travis.yml and appveyor.yml too.
@codecov

This comment has been minimized.

codecov bot commented Apr 12, 2018

Codecov Report

Merging #259 into master will increase coverage by 0.09%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
+ Coverage   75.75%   75.84%   +0.09%     
==========================================
  Files          33       33              
  Lines        2409     2414       +5     
  Branches      132      132              
==========================================
+ Hits         1825     1831       +6     
+ Misses        452      451       -1     
  Partials      132      132
Impacted Files Coverage Δ
src/Nirum/Docs.hs 58.9% <100%> (+2.38%) ⬆️
src/Nirum/Targets/Docs.hs 65.3% <75%> (+0.35%) ⬆️
src/Nirum/Constructs/Module.hs 65.9% <0%> (+2.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b08904...dc13fd9. Read the comment docs.

@dahlia dahlia merged commit ac4b2db into nirum-lang:master Apr 15, 2018

4 checks passed

codecov/patch 87.5% of diff hit (target 75.75%)
Details
codecov/project 75.84% (+0.09%) compared to 1fee501
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dahlia dahlia added this to the Version 0.4.0 milestone May 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment