New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add classifiers field to package metadata #269

Merged
merged 1 commit into from May 12, 2018

Conversation

Projects
3 participants
@earlbread
Contributor

earlbread commented May 12, 2018

Close #100.

@earlbread earlbread force-pushed the earlbread:add-classifier-to-metadata branch from 3202a66 to 4a165ce May 12, 2018

@kanghyojun kanghyojun requested a review from dahlia May 12, 2018

CHANGES.md Outdated
@@ -175,6 +175,8 @@ To be released.
Under the hood, all generated `import`s are now aliased with a name prefixed
an underscore.

- Add python classifier metadata field. [[#100]]

This comment has been minimized.

@dahlia

dahlia May 12, 2018

Member

Please use the past tense, and change the first letter of “python” to the capital letter “P.”

This comment has been minimized.

@dahlia

dahlia May 12, 2018

Member

It would be better if it links this PR number as well.

@earlbread earlbread force-pushed the earlbread:add-classifier-to-metadata branch from 4a165ce to c348ade May 12, 2018

@dahlia dahlia added this to In progress in Sprint at Seoul in May 2018 May 12, 2018

@dahlia

dahlia approved these changes May 12, 2018

@codecov

This comment has been minimized.

codecov bot commented May 12, 2018

Codecov Report

Merging #269 into master will decrease coverage by 0.02%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #269      +/-   ##
==========================================
- Coverage   76.16%   76.14%   -0.03%     
==========================================
  Files          33       33              
  Lines        2446     2452       +6     
  Branches      132      131       -1     
==========================================
+ Hits         1863     1867       +4     
- Misses        451      454       +3     
+ Partials      132      131       -1
Impacted Files Coverage Δ
src/Nirum/Package/Metadata.hs 80.28% <ø> (+0.7%) ⬆️
src/Nirum/Targets/Python/CodeGen.hs 86.86% <0%> (-0.89%) ⬇️
src/Nirum/Targets/Python.hs 89.25% <60%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fb4391...c348ade. Read the comment docs.

@dahlia dahlia merged commit 814f455 into nirum-lang:master May 12, 2018

2 of 4 checks passed

codecov/patch 50% of diff hit (target 76.16%)
Details
codecov/project 76.14% (-0.03%) compared to 6be588a
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Sprint at Seoul in May 2018 automation moved this from In progress to Delivered May 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment